Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a bunch of things from X11 headers needed for implementing clipboard interfacing #36

Merged
merged 8 commits into from Apr 21, 2015

Conversation

@aweinstock314
Copy link
Contributor

aweinstock314 commented Mar 28, 2015

No description provided.

@jdm
Copy link
Member

jdm commented Mar 28, 2015

@aweinstock314
Copy link
Contributor Author

aweinstock314 commented Apr 6, 2015

This is failing to build on travis due to the dependency Xmu ("/usr/lib/x86_64-linux-gnu/libXmu.a" on the Debian system I'm using for development) not being found. Xmu contains the symbol _XA_CLIPBOARD (declared extern in "/usr/include/X11/Xmu/Atoms.h"), which is an X11 Atom (interned string) used as part of the protocol(s) involving the clipboard. How do I go about adding Xmu to the relevant dependencies list (assuming that's the correct way to go about resolving this)?

@Manishearth
Copy link
Member

Manishearth commented Apr 6, 2015

Add an install key:

install:
 - sudo apt-get install foobar

You will have to remove the sudo: false from the top, sadly

@metajack
Copy link
Contributor

metajack commented Apr 6, 2015

This will prevent it from using containerized builds, which means it will be slower to go through CI. If we can avoid an apt-get dep we should, but if we can't, we'll just have to live with the degraded performance.

@jdm
Copy link
Member

jdm commented Apr 6, 2015

I assume we want libxmu6-dev, not just libxmu6?

@aweinstock314 aweinstock314 force-pushed the aweinstock314:master branch from f04891b to e000f79 Apr 6, 2015
jdm added a commit that referenced this pull request Apr 21, 2015
Added a bunch of things from X11 headers needed for implementing clipboard interfacing
@jdm jdm merged commit 1a0f3d4 into servo:master Apr 21, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.