Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot-master needs python3 #142

Closed
Manishearth opened this issue Oct 30, 2015 · 2 comments
Closed

buildbot-master needs python3 #142

Manishearth opened this issue Oct 30, 2015 · 2 comments

Comments

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 30, 2015

Homu only works on a python3 toolchain. Our salt configuration does not autoinstall this.

Homu worked so far because it somehow had a python3 virtualenv with everything it needed, without a global install of any of the python3 tools.

Specifically, we need:

sudo apt-get install python3.4 python3-pip
pip3 install virtualenv

We can do the former with a - require: - pkg: key in homu.sls somewhere.

I'm not sure how to indicate a pip3-specific dependency, though. Perhaps something with bin_env?

We also need to make sure that the pip/python/virtualenv setup does not make 3.4 the default for the pip/python/virtualenv binaries. Installing them as shown above seemed to preserve the default, but I'm not sure if that's something we can rely on.

cc @edunham @larsbergstrom
@edunham
Copy link
Contributor

@edunham edunham commented Oct 30, 2015

We might run into saltstack/salt#5494 with Salt. One workaround would be to create the virtualenv, with the flags telling it to use python3, through a shell command.
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented Oct 30, 2015

Huh. It worked for us, the current salt configuration just says "virtualenv.managed, but use the binary called virtualenv3.4" and it works
@aneeshusa aneeshusa mentioned this issue Nov 1, 2015
Merged
aneeshusa added a commit to aneeshusa/servo-saltfs that referenced this issue Nov 4, 2015
@aneeshusa
Standardize python setup, ensure homu gets python3
9295f2a 
- Trusty comes with python3, pip and virtualenv by default, but write
states defensively to install these dependencies as required and require
the pip or virtualenv states as used by other states.
- Homu requires a python3 toolchain, use virtualenv-3.4 and pass python:
  python3 to get the correct setup (including pip3 inside the venv).
- Update the style guide example to use pkg.installed instead of
  pip.installed to avoid muddling it with a require: pip.
Fixes servo#142.
@aneeshusa aneeshusa mentioned this issue Nov 4, 2015
Merged
aneeshusa added a commit to aneeshusa/servo-saltfs that referenced this issue Nov 4, 2015
@aneeshusa
Standardize python setup, ensure homu gets python3
929a16d 
- Trusty comes with python3, pip and virtualenv by default, but write
states defensively to install these dependencies as required and require
the pip or virtualenv states as used by other states.
- Homu requires a python3 toolchain, use virtualenv-3.4 and pass python:
  python3 to get the correct setup (including pip3 inside the venv).
- Update the style guide example to use pkg.installed instead of
  pip.installed to avoid muddling it with a require: pip.
Fixes servo#142.
aneeshusa added a commit to aneeshusa/servo-saltfs that referenced this issue Feb 11, 2016
@aneeshusa
Standardize python setup, ensure homu gets python3
55ca2e9 
- Trusty comes with python3, pip and virtualenv by default, but write
states defensively to install these dependencies as required and require
the pip or virtualenv states as used by other states.
- Homu requires a python3 toolchain, use virtualenv-3.4 and pass python:
  python3 to get the correct setup (including pip3 inside the venv).
- Update the style guide example to use pkg.installed instead of
  pip.installed to avoid muddling it with a require: pip.
Fixes servo#142.
aneeshusa added a commit to aneeshusa/servo-saltfs that referenced this issue Feb 11, 2016
@aneeshusa
Standardize python setup, ensure homu gets python3
e2a8efc 
- Trusty comes with python3, pip and virtualenv by default, but write
states defensively to install these dependencies as required and require
the pip or virtualenv states as used by other states.
- Homu requires a python3 toolchain, use virtualenv-3.4 and pass python:
  python3 to get the correct setup (including pip3 inside the venv).
- Update the style guide example to use pkg.installed instead of
  pip.installed to avoid muddling it with a require: pip.
Fixes servo#142.
bors-servo added a commit that referenced this issue Feb 11, 2016
@bors-servo
Auto merge of #148 - aneeshusa:ensure-python3-venv-for-homu, r=larsbe…
Loading status checks…
dcb4771 
…rgstrom

Standardize python setup, ensure homu gets python3

- Trusty comes with python3, pip and virtualenv by default, but write
states defensively to install these dependencies as required and require
the pip or virtualenv states as used by other states.
- Homu requires a python3 toolchain, use virtualenv-3.4 and pass python:
  python3 to get the correct setup (including pip3 inside the venv).
- Update the style guide example to use pkg.installed instead of
  pip.installed to avoid muddling it with a require: pip.

Fixes #142.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/148)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@edunham @Manishearth
You can’t perform that action at this time.