Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildmaster API needs a password #172

Closed
edunham opened this issue Dec 11, 2015 · 3 comments
Closed

Buildmaster API needs a password #172

edunham opened this issue Dec 11, 2015 · 3 comments
Assignees
@edunham

Comments

@edunham
Copy link
Contributor

@edunham edunham commented Dec 11, 2015

Could be possible to trigger arbitrary builds right now.
@edunham edunham self-assigned this Dec 11, 2015
@metajack
Copy link
Contributor

@metajack metajack commented Dec 11, 2015

It has one I'm pretty sure. Check the config and secrets file.
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 11, 2015

The force build button is still visible here without being logged in. http://build.servo.org/builders/linux-rel
@edunham edunham mentioned this issue Mar 23, 2016
Merged
bors-servo added a commit that referenced this issue Mar 23, 2016
@bors-servo
Auto merge of #272 - edunham:auth, r=larsbergstrom
Loading status checks…
57aa7a0 
Require auth for all buildbot actions

http://docs.buildbot.net/0.8.1/WebStatus-Configuration-Parameters.html

Addresses #172

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/272)
<!-- Reviewable:end -->
@edunham
Copy link
Contributor Author

@edunham edunham commented Mar 24, 2016

OK, now that that's deployed... Saying 'True' rather than 'auth' for all actions meant anybody could force and kill builds, regardless of login status. @metajack was correct that a password was set, but the prior config missed the step of testing whether or not the user was authed before allowing all actions.
@edunham edunham closed this Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edunham edunham

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@metajack @edunham @Manishearth
You can’t perform that action at this time.