Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize try and non-try jobs #179

Closed
Ms2ger opened this issue Dec 19, 2015 · 8 comments
Closed

Serialize try and non-try jobs #179

Ms2ger opened this issue Dec 19, 2015 · 8 comments

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 19, 2015

I think running those in parallel might be what's causing homu to get confused.

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 19, 2015

I think the confusion wasn't due to this; it was because homu got restarted just at the same time it got some build results from buildbot, tainting its status forever in the build db.

(I tried to fix this by manipulating the pulls db, I should have tweaked the build db instead)

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Dec 19, 2015

How does this "restart" happen? Is it a normal workflow that homu goes through, or is it due to user interaction?

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 19, 2015

User interaction. When pulling in a new config or something

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Dec 19, 2015

So in other words, whenever we pull a new config, we'll have to make sure the following happens:

  • Stop any builds that are current
  • Comment on the PR related to the build about the stoppage
  • Update the build database
  • Pull in the new config
  • Resume and message all outstanding builds
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 19, 2015

Well, usually I try to update the configs when there are no builds, or when there's no chance of a build notification, in case something like this happens.

It's a bit hard to stop current builds since homu will just go on to the next one.

@metajack
Copy link
Contributor

@metajack metajack commented Dec 20, 2015

I've asked @barosl for a feature to pause homu several times. Maybe someday we'll get that. For now you pretty much need to stop the service to stop it progressing builds, but then all the build notifications are dropped on the floor.

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 20, 2015

I've never looked at the homu code around this, but I probably could implement it; doesn't sound hard. If we're adding this might as well also add a treeclosed state which closes the tree for everything with p<10000 or something (for rustups and stuff)

@edunham
Copy link
Contributor

@edunham edunham commented Jul 5, 2017

Closing this in favor of servo/homu#129 because it wasn't actually a Try problem

@edunham edunham closed this Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.