Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run new test-compiletest harness on builders #216

Closed
jdm opened this issue Feb 5, 2016 · 3 comments
Closed

Run new test-compiletest harness on builders #216

jdm opened this issue Feb 5, 2016 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 5, 2016

Currently we only run on travis, so our merges don't gate on the testsuite passing.
@jdm
Copy link
Member Author

@jdm jdm commented Apr 8, 2016

This bit us when we removed a rustc plugin but not the corresponding unit tests :(
@jdm jdm mentioned this issue Apr 8, 2016
Merged
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 10, 2016

Which platforms do we need to run this on/is this platform agnostic? For example, can we run this only on the linux-dev builder, or should we be running this on all platforms - development, release, ARM, OS X, etc?
@jdm
Copy link
Member Author

@jdm jdm commented Apr 10, 2016

Linux-dev should be enough.
@aneeshusa aneeshusa mentioned this issue Apr 10, 2016
Merged
bors-servo added a commit that referenced this issue Apr 10, 2016
@bors-servo
Auto merge of #313 - aneeshusa:run-compiletest, r=Manishearth
Loading status checks…
2dbe34a 
Run compiletest on linux-dev

The compiletest test is quick to run and shouldn't increase
build times very much.

Fixes #216.

cc @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/313)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @aneeshusa
You can’t perform that action at this time.