Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded IPs #288

Closed
edunham opened this issue Mar 30, 2016 · 6 comments
Closed

Remove hardcoded IPs #288

edunham opened this issue Mar 30, 2016 · 6 comments
Labels
E-easy help wanted

Comments

@edunham
Copy link
Contributor

@edunham edunham commented Mar 30, 2016

Follow-up from discussion in #281 .

We have a bunch of IPs hardcoded into common/map.jinja. This was useful when we had to manage DNS through Mozilla support tickets, but we control everything directly through CloudFlare now.

Todo:

  • Remove the IPs from map.jinja
  • Remove the states which add the IPs to the hosts file
  • Test everything in Vagrant
  • Deploy changes to one buildslave, see if it still connects and runs builds successfully
@edunham
Copy link
Contributor Author

@edunham edunham commented Mar 30, 2016

Duplicate of #287
@edunham edunham closed this Mar 30, 2016
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 1, 2016

This is clearer and has better instructions than the other issue I opened, so closing it in favor of reopening this one.
@aneeshusa aneeshusa reopened this May 1, 2016
@aneeshusa aneeshusa mentioned this issue May 1, 2016
Closed
@setupminimal
Copy link
Contributor

@setupminimal setupminimal commented May 9, 2016

Hi! I'm looking to contribute to Servo, and this was mentioned on Servo Starters, so I'm going to try it. Thanks!
@aneeshusa aneeshusa added the C-assigned label May 9, 2016
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 9, 2016

@setupminimal It's yours, let us know if you have any questions!
@setupminimal setupminimal mentioned this issue May 10, 2016
Closed
@tictakk
Copy link

@tictakk tictakk commented Apr 20, 2017

Hey I'm a little confused, is this still an issue? Is this still assigned?
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 20, 2017

This actually got taken care of in 95ab185 already, thanks for checking!
@aneeshusa aneeshusa closed this Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@jdm @edunham @aneeshusa @setupminimal @tictakk
You can’t perform that action at this time.