Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC Timezone #303

Closed
aneeshusa opened this issue Apr 6, 2016 · 6 comments
Closed

Use UTC Timezone #303

aneeshusa opened this issue Apr 6, 2016 · 6 comments

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 6, 2016

This should be applied to all machines, so this should go into the common/init.sls file.

We can use the timezone.system state to configure a UTC timezone (docs).

I think this would be a great E-Easy issue.

(A follow-up would be ensuring that NTP is on and configured on all machines, but there's no Salt state for this yet so that wouldn't be E-Easy.)

@aneeshusa aneeshusa added the E-easy label Apr 8, 2016
@ghost
Copy link

@ghost ghost commented Jul 1, 2016

I'll start working on this.

@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Jul 1, 2016

It's all yours! Let me know if you have any questions.

@ghost
Copy link

@ghost ghost commented Jul 15, 2016

I think I've correctly added this, should I go about working on adding NTP support, or will that be done from a separate issue?

@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Jul 15, 2016

Let's save NTP for another issue/PR; that one will be more involved because we will need to write custom Salt code for that. (It's also blocked on #350, which will enable us to load custom modules and states).

@jdm jdm removed the C-assigned label Oct 18, 2016
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Dec 29, 2016

@charlesvdv is interested in taking this up now: #439 (comment)

bors-servo added a commit that referenced this issue Jan 7, 2017
Use UTC timezone

Fix the issue #303 and follow up of #439 PR.

I'm not sure about the spot to put the ```sls.common``` tests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/569)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Jan 19, 2017

Looks like this was fixed by #569.

@jdm jdm closed this Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.