Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmake sure servo user has perms on files needed to start buildbot #332
Comments
|
What command did you use to start buildbot as root? I'd rather make it impossible to do so by checking the UID. I'll make a PR to ensure the whole directory is owned by servo:servo. |
bors-servo
added a commit
that referenced
this issue
May 5, 2016
Ensure Buildbot master files are owned by servo If the Buildbot master is ever erroneously started as root, the permissions on a variety of files in the Buildbot master dir are clobbered and the Buildbot master process is unable to access them. Use a file.directory state to set ownership to servo:servo for the whole folder, so that a highstate will restore the correct permissions in case this happens. Fixes #332. r? @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/334) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
if buildbot is ever erroneously started as root, it clobbers the perms on a bunch of files (twistd.log, events_build.servo.org/state, etc) that servo user needs access to in order to successfully start buildbot. it'd be nice if a highstate restored the correct perms.
a
chown -R servo:servo /home/servo/buildbotdoes the trick.