Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use steps.Test instead of steps.Compile for './mach test-unit' on Windows #343

Closed
aneeshusa opened this issue Apr 27, 2016 · 0 comments
Closed

Use steps.Test instead of steps.Compile for './mach test-unit' on Windows #343

aneeshusa opened this issue Apr 27, 2016 · 0 comments
Labels
E-easy L-python

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 27, 2016

The Windows Buildbot factory has a hard-coded list of steps, since the heuristics added in #325 can't yet handle the extra Windows boilerplate. The second step runs ./mach test-unit; until our heuristics are fixed (not so easy), this should be run as a steps.Test step instead of a steps.Compile step.

Files:

  • buildbot/master/files/config/factories.py
@CorcovadoMing CorcovadoMing mentioned this issue Apr 28, 2016
Merged
bors-servo added a commit that referenced this issue Apr 28, 2016
@bors-servo
Auto merge of #345 - CorcovadoMing:patch-1, r=aneeshusa
Loading status checks…
71e7463 
Use steps.Test instead of steps.Compile

fix #343

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/345)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 28, 2016
@bors-servo
Auto merge of #345 - CorcovadoMing:patch-1, r=aneeshusa
Loading status checks…
fd89f2b 
Use steps.Test instead of steps.Compile

fix #343

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/345)
<!-- Reviewable:end -->
@irvin irvin mentioned this issue Jan 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy L-python
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Use steps.Test instead of steps.Compile
1 participant
@aneeshusa
You can’t perform that action at this time.