Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pkill on the Windows builders #351

Closed
aneeshusa opened this issue May 1, 2016 · 4 comments
Closed

Run pkill on the Windows builders #351

aneeshusa opened this issue May 1, 2016 · 4 comments

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 1, 2016

Our Linux and OS X builders use pkill before each build to ensure there are no extra servo processes.

We should also run this on the Windows builders. The best way to do this would be to write a custom script in the etc/ci directory of the main servo repository, which runs pkill on Linux/OS X, or the corresponding command on Windows (possibly taskkill /im servo.exe, see this comment).

A possible complication is that we run Windows commands inside a bash shell; this script should either work from inside that shell, or be run outside of it.

@retep998
Copy link

@retep998 retep998 commented Jun 11, 2016

You know what else you could do? Use job objects. Rust uses job objects to very good effect on its builders, and they ensure that there are no child processes of any sort hanging around.

Originally Rust used https://github.com/retep998/dojob-rs although recently it switched to https://github.com/alexcrichton/rustjob to avoid killing mspdbsrv.exe

@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Jun 11, 2016

Do you have a doc link for job objects? Are they similar to control groups on Linux? (I'd love to use process/control groups for much better control, but that will take some time to investigate, and I'm not sure about an equivalent for OS X.)

@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Jul 8, 2016

Fixed in #426 using powershell kill -n servo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.