Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up this repo to highfive #353

Closed
aneeshusa opened this issue May 3, 2016 · 8 comments
Closed

Hook up this repo to highfive #353

aneeshusa opened this issue May 3, 2016 · 8 comments

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 3, 2016

Add a webhook pointing at http://www.joshmatthews.net/highfive/newpr.py. See servo/highfive#109 (comment).
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented May 3, 2016

I think I did it correctly - we'll see on the next PR open by somebody new!
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented May 4, 2016

I don't think this is set up properly - see #359 where highfive didn't leave a comment.
@aneeshusa aneeshusa reopened this May 4, 2016
@jdm
Copy link
Member

@jdm jdm commented May 4, 2016

We may need a Robots team like the main servo repo does.
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented May 5, 2016

Should be fixed now: http://logs.glob.uno/?c=mozilla%23servo#c422225
@aneeshusa aneeshusa closed this May 5, 2016
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented May 10, 2016

Apparently still not fixed - Highfive didn't leave a comment on #369, either.
@aneeshusa aneeshusa reopened this May 10, 2016
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Oct 2, 2016

Looks like this is working as of #499, will close this after 1/2 more PRs to verify.
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Oct 2, 2016

FYI, @jdm was right - the Robots group did not have write access to the repo. After adding that this Friday, it seems to be working.
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Oct 2, 2016

Ah ok, in that case since it didn't just spontaneously start working, this should be good to go.
@aneeshusa aneeshusa closed this Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @larsbergstrom @aneeshusa
You can’t perform that action at this time.