Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builder is not caching cargo and rust deps #358

Closed
larsbergstrom opened this issue May 4, 2016 · 3 comments
Closed

Windows builder is not caching cargo and rust deps #358

larsbergstrom opened this issue May 4, 2016 · 3 comments
Labels

Comments

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented May 4, 2016

Need to set the CARGO_HOME and SERVO_CACHE_DIR environment variables to something sensible to avoid wasting a ton of time on our Windows builder.

Changes should be made to this file:
https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/environments.py

@larsbergstrom larsbergstrom added the E-easy label May 4, 2016
@jdm jdm added the L-python label May 4, 2016
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 4, 2016

Specifically, these variables should be added to the build_windows expression.

@jeandudey
Copy link

@jeandudey jeandudey commented May 5, 2016

What about using %APPDATA%\.cargo for CARGO_HOME and %APPDATA%\.servo for SERVO_CACHE_DIR?

@larsbergstrom
Copy link
Contributor Author

@larsbergstrom larsbergstrom commented May 5, 2016

@jeandudey That sounds great to me, and much better than my other hacky ideas! The one good thing to test locally is to make sure that env vars get properly expanded when set and used by Cargo, as otherwise the files will still end up in the directory that gets cleared every time!

bors-servo added a commit that referenced this issue May 6, 2016
Add caching of Cargo and Rust bits to Windows

r? @edunham @aneeshusa

Fixes #358

I decided to use the msys home dir instead of `%APPDATA%` for consistency with the other unix builds, but could be convinced otherwise if we get to a point where Servo is not building inside of the msys/mingw environment.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/362)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.