Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse steps.Compile for `mach package` on Buildbot #372
Closed
Labels
Comments
|
I would like to implement this. If I understand correctly, we should check that |
|
@lucasloisp that's correct! I've assigned this to you, leave a comment if you have any questions. Note: there are currently two copies of |
lucasloisp
added a commit
to lucasloisp/saltfs
that referenced
this issue
Oct 5, 2016
This command is used during the Android APK build, but even though it failed, Buildbot still went on to run the next step, because it used to be run as a simple ShellCommand (as per issue servo#372). Instead, we now check for it on the `make_step` function and use `steps.Compile` to create the step as it is not only a closer semantic match (we're "compiling" the APK) but it also makes it so when it fails Builbot doesn't ignore it or move on to the next step.
bors-servo
added a commit
that referenced
this issue
Oct 12, 2016
…husa `mach package` treated as a steps.Compile @aneeshusa: as per issue #372, both `make_step` now have a heuristic for checking that the argument passed to mach (`mach_arg`) is `'package'` and assigns `step_class = steps.Compile` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/503) <!-- Reviewable:end -->
|
Fixed by #503. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use
./mach package -rto package Android APKs on the android-nightly builder; the next step is then to upload the built package via S3.Currently, the packaging step is broken (should be fixed by #290); however, even though it fails, Buildbot still tries to run the next step of uploading to S3. This is because there is no heuristic for
./mach packageand it is run as a regularShellCommand.Instead, we should add a heuristic in the
make_stepfunction in thebuildbot/master/files/config/factories.pyfile that checks for./mach packageand uses steps.Compile to create that step. This a) is a closer semantic match (we're "compiling" the APK), and b) will stop the build if the packaging fails, so Buildbot doesn't try the S3 upload step.This can simply check for
packageas an argument to mach instead of using a more complicated regex as the other heuristics do, because currently there is only one type of packaging: Android APK.