Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nightly tests of the saltfs repo #376

Closed
aneeshusa opened this issue May 19, 2016 · 9 comments
Closed

Run nightly tests of the saltfs repo #376

aneeshusa opened this issue May 19, 2016 · 9 comments

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 19, 2016

We should run the full saltfs suite (from scratch) on Travis every night to catch changes in upstreams (e.g. #314).

@edunham I think you like to use nightli.es for this purpose? We should also have some form of alerting on failure, but I'm not sure of a good way to do that.

@edunham
Copy link
Contributor

@edunham edunham commented Jun 20, 2016

We can configure Travis to send email or IRC notifications of build status, https://docs.travis-ci.com/user/notifications/. I think emails will be the best communication channel for me. @larsbergstrom, would / where would you like notifications?

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Jun 20, 2016

I agree that email is probably the best of the options. The awesomest would be automatically opening a GH issue in the case of failure, but I don't think that's an available option :-)

@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Sep 22, 2016

Ping on this, would have helped catch #483.

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Sep 22, 2016

@edunham could we use an alias on servo.org? e.g., github-saltfs@servo.org

@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Sep 23, 2016

I opened #376 for this, but I see a few problems with this solution:

  • I am unaware of any way to filter notifications by branch. Because homu always uses the auto branch, even though Travis does not send notifications for PRs this will send extra emails when going through bors-servo, causing lots of spam.
  • Having an (internal?) email list adds more state, somewhere that is not 1) openly visible 2) likely not under version control of some kind. What does the process look like for changing that list?
  • If we add this to other repos, we'd start wanting one list per repo, which is a lot of lists to keep track of (e.g. which lists am I on? did we remember to enable notifications on [new repo] yet?)

I think it may be time to invoke Zawinski's Law and add email features to homu, where we can add a few more smarts and standardize this a bit, making it available to all repos easily.

@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Jan 21, 2017

Apparently Travis has a new feature called Crons which allows natively scheduling nightly builds. It looks like this is still in Beta but on the cusp of going GA - I believe it can be enabled through the Travis console, possibly after a support request.

I think IRC notifications would be fine to start with, although I suppose an email alias would work as well.

@edunham
Copy link
Contributor

@edunham edunham commented Feb 9, 2017

Nightly builds are now enabled and #598 adds notification in the bots channel on all builds.

bors-servo added a commit that referenced this issue Feb 9, 2017
notify travis status in servo-bots channel

this is the other half of fixing #376

i have already turned on nightly builds via travis's experimental cron feature

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/598)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Feb 11, 2017

@edunham Do you know if this is working? Just got hit by a new failure (see #601), but I'm not sure if Travis ran a nightly build yesterday.

@edunham
Copy link
Contributor

@edunham edunham commented Feb 14, 2017

@aneeshusa Travis is reporting that it kicked off a cron about 15 minutes ago, which corresponds to the start time of https://travis-ci.org/servo/saltfs/builds/201652835. One can see the cron "last run" time on https://travis-ci.org/servo/saltfs/settings. According to the conversation in travis-ci/beta-features#1, one can tell that the afforementioned build was triggered by cron because its icon by the build number looks a bit like a lego with a clock, rather than the usual icon.

@edunham edunham closed this Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.