Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import color constant for red instead of using magic number #378

Closed
aneeshusa opened this issue May 19, 2016 · 2 comments
Closed

Import color constant for red instead of using magic number #378

aneeshusa opened this issue May 19, 2016 · 2 comments
Labels
E-easy L-python

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 19, 2016

Our test output is colorized for readability, and it uses ANSI escape codes to do so. The tests/util.py file has constants for the colors that we use. The tests/lint/trailing_whitespace.py test should import the RED constant from the tests/util.py file instead of hard-coding 31.
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented May 24, 2016

There is an open PR for this.
@KiChjang KiChjang removed the C-assigned label Jun 17, 2016
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jun 17, 2016

Previous attempt at #381.
@leahnp leahnp mentioned this issue Jun 18, 2016
Merged
bors-servo added a commit that referenced this issue Jun 18, 2016
@bors-servo
Auto merge of #400 - leahnp:redconstant, r=aneeshusa
Loading status checks…
80e3c43 
Replaced hard coded color with RED constant from utils.py

This is to fix: #378

#381 had been closed due to inactivity so I picked this task to start contributing to servo. Hopefully this resolves the outstanding comments from 381.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/400)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy L-python
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Replaced hard coded color with RED constant from utils.py
2 participants
@aneeshusa @KiChjang
You can’t perform that action at this time.