Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd test that generated `cfg.toml` for Homu is a valid TOML file #407
Labels
Comments
|
Hey, I've made an attempt at doing this on a fork by using a Python library. Two problems though:
This is my first pull request to a public repo, so thank you very much for the detailed description of what you wanted done! Made making a first contribution pretty easy :) |
|
Welcome to Servo!
Please go ahead and open a PR with your changes, even if incomplete, to make it easier to provide review comments; we can continue the discussion there. |
Merged
bors-servo
added a commit
that referenced
this issue
Jul 11, 2016
Validate Homu TOML file Draft of resolution to #407. `config_path` in sls/homu/toml.py is definitely wrong and should be corrected <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/420) <!-- Reviewable:end -->
|
Fixed by #420. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Buildbot has a
checkconfigcommand to check that the master configuration file is valid, which we test intests/sls/buildbot/master/config.py. AFAIK there is no similar command for Homu yet, but it should be possible to check that thecfg.tomlfile parses as TOML at the least using a Python TOML library. This should help prevent issues like the one addressed in #405.A more comprehensive alternative that requires more work is creating such a
checkconfigcommand for Homu, and writing a test that uses that instead.Files:
tests/sls/homu/folder and make a new Python file inside with the test. Also include an empty__init__.pyfile in that folder.tomllibrary to therequirements.txtfile, so it is available on Travis. This is the library used by Homu; ideally, this is pinned to the same version that Homu uses..travis/dispatch.shfile to run the new test on theservo-master1node.