Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Buildbot categories #412

Closed
aneeshusa opened this issue Jun 30, 2016 · 3 comments
Closed

Remove Buildbot categories #412

aneeshusa opened this issue Jun 30, 2016 · 3 comments
Labels
C-assigned C-has open PR E-easy L-python

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Jun 30, 2016

In #16, we added Buildbot categories, but I'm not sure if we ever used them. At this point in time, all of our builders are getting the same category value - "auto" - which we're not doing anything with (they can be used to filter Buildbot status targets). Additionally, the categories parameter was deprecated in Buildbot 0.8.12, the version we are running, so they are due to be removed anyways.

Files:

  • buildbot/master/files/config/master.cfg

No need to add any new tests for this change.
@this-jacob this-jacob mentioned this issue Jun 30, 2016
Merged
@rozuur
Copy link

@rozuur rozuur commented Jul 1, 2016

I would like to work on this as my first PR. Other than removing categories from master.cfg is there anything that needs to be done?
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Jul 1, 2016

@rozuur @this-jacob already has a PR open for this one! Feel free to try one of the other issues tagged E-easy, though.
bors-servo added a commit that referenced this issue Jul 1, 2016
@bors-servo
Auto merge of #419 - this-jacob:remove_buildbot_categories, r=aneeshusa
Loading status checks…
351fc5d 
Removed Buildbot Categories

Addresses Issue: #412

Removed unused categories on the builders.

Additionally  the `categories` parameter was deprecated in Buildbot 0.8.12 (the version currently in use)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/419)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Jul 1, 2016

Fixed by #419.
@aneeshusa aneeshusa closed this Jul 1, 2016
@aneeshusa aneeshusa mentioned this issue Jul 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned C-has open PR E-easy L-python
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@rozuur @aneeshusa
You can’t perform that action at this time.