Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't put the homu database in /home/servo/homu directory #456

Closed
aneeshusa opened this issue Aug 10, 2016 · 5 comments
Closed

Don't put the homu database in /home/servo/homu directory #456

aneeshusa opened this issue Aug 10, 2016 · 5 comments
Labels
C-assigned C-has open PR E-easy

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Aug 10, 2016 •
edited

We recently deleted the main main.db database by accident while debugging a Homu problem; the /home/servo/homu directory was blown away and the database with it.

To make it harder to blow away the database inadvertently, we should put the database in a different location. I think /var/homu/main.db would be a good option. We also need to add a Salt state to pre-create the /var/homu directory with the correct permissions for Homu to use it.

Homu first needs to land an option to change the main.db location.

Files:

  • homu/files/cfg.toml
  • homu/init.sls

No test necessary for now.

cc @larsbergstrom
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Aug 10, 2016

Yeah, that makes sense :-)
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Aug 20, 2016

This has been fixed in Homu, so this is open for anyone to work on!
@Coder206
Copy link
Contributor

@Coder206 Coder206 commented Aug 29, 2016

@aneeshusa I'd like to help out here.
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented Aug 29, 2016

@Coder206 It's yours, please ask if you have any questions!
@Coder206 Coder206 mentioned this issue Sep 11, 2016
Merged
@jdm jdm added the C-has open PR label Oct 18, 2016
bors-servo added a commit that referenced this issue Apr 22, 2017
@bors-servo
Auto merge of #476 - Coder206:homuDB, r=aneeshusa
Loading status checks…
d77ca7a 
Changing DB location for Homu

Here is some code that attempts to solve #456.

cc @aneeshusa

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/476)

<!-- Reviewable:end -->
@aneeshusa
Copy link
Member Author

@aneeshusa aneeshusa commented May 11, 2017

This was fixed by #476, which has been deployed. Thanks @Coder206!
@aneeshusa aneeshusa closed this May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned C-has open PR E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @larsbergstrom @aneeshusa @Coder206
You can’t perform that action at this time.