Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildbot no longer exposes the logs from multiple test jobs #524

Closed
Ms2ger opened this issue Oct 28, 2016 · 2 comments
Closed

Buildbot no longer exposes the logs from multiple test jobs #524

Ms2ger opened this issue Oct 28, 2016 · 2 comments

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 28, 2016

http://build.servo.org/builders/linux-rel-wpt/builds/468 has three test jobs, but all links point to the log for the first one.
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Oct 28, 2016

I've identified this as a bug in the new dynamic step creator and am working on a PR for this.
@aneeshusa aneeshusa mentioned this issue Oct 28, 2016
Merged
bors-servo added a commit that referenced this issue Oct 28, 2016
@bors-servo
Auto merge of #525 - aneeshusa:ensure-steps-have-unique-names, r=meta…
Loading status checks…
43a07c5 
…jack

Ensure dynamic Buildbot steps have unique names

Buildbot requires that each step in a build has a unique name,
and uses this property to e.g. disambiguate log files.
By default, each step's name reflect what kind of step it is,
e.g. `git` or `test`.

Add count suffixes to the end of the step name if there are
multiple steps of the same type to disambiguate them.
(Buildbot already does this internally for steps added statically
in the `setupBuild` method).

This requires checking all previously-added steps for name collisions,
so add all the steps at one time to amortize this cost.

Fixes #524.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/525)
<!-- Reviewable:end -->
@aneeshusa aneeshusa mentioned this issue Oct 28, 2016
Closed
bors-servo added a commit that referenced this issue Oct 28, 2016
@bors-servo
Auto merge of #525 - aneeshusa:ensure-steps-have-unique-names, r=lars…
Loading status checks…
ac520bc 
…bergstrom

Ensure dynamic Buildbot steps have unique names

Buildbot requires that each step in a build has a unique name,
and uses this property to e.g. disambiguate log files.
By default, each step's name reflect what kind of step it is,
e.g. `git` or `test`.

Add count suffixes to the end of the step name if there are
multiple steps of the same type to disambiguate them.
(Buildbot already does this internally for steps added statically
in the `setupBuild` method).

This requires checking all previously-added steps for name collisions,
so add all the steps at one time to amortize this cost.

Fixes #524.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/525)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Oct 28, 2016

FYI there were some fixups required (#526, #528), but this seems to be working properly now.
@aneeshusa aneeshusa mentioned this issue Oct 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Ensure dynamic Buildbot steps have unique names
2 participants
@Ms2ger @aneeshusa
You can’t perform that action at this time.