Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homebrew nightly build not updated anymore (since 26) #532

Closed
paulrouget opened this issue Oct 31, 2016 · 4 comments
Closed

Homebrew nightly build not updated anymore (since 26) #532

paulrouget opened this issue Oct 31, 2016 · 4 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Oct 31, 2016

Last update was on the 26th of October: https://github.com/servo/homebrew-servo

Does ./etc/ci/update_brew.sh still run?
@jdm
Copy link
Member

@jdm jdm commented Oct 31, 2016

https://github.com/servo/servo/blob/master/etc/ci/buildbot_steps.yml#L29 says it should be.
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Oct 31, 2016

It seems that the TOKEN variable is unbound: http://build.servo.org/builders/mac-nightly/builds/129/steps/shell__3/logs/stdio, causing the upload to fail.

Will investigate further after class.
@aneeshusa aneeshusa mentioned this issue Oct 31, 2016
Merged
bors-servo added a commit that referenced this issue Oct 31, 2016
@bors-servo
Auto merge of #533 - aneeshusa:re-provide-homebrew-upload-token, r=la…
Loading status checks…
6e151a5 
…rsbergstrom

Re provide homebrew upload token

 This was added to the previous `make_step` implementation,
but apparently was not copied over to this implementation,
causing our Homebrew uploads to fail for the last 4 days.
Re-add this logic.

Note that because adding the token to the environment and telling
Buildbot not to log the environment are configured together,
the token was not leaked during this time.

r? @larsbergstrom
Fixes #532.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/533)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Oct 31, 2016

Reopening until mac-nightly runs again tonight and I can confirm that this is working again.
@aneeshusa aneeshusa reopened this Oct 31, 2016
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Oct 31, 2016

@larsbergstrom started a force build and this is working again: servo/homebrew-servo@3ec0ce0.
@aneeshusa aneeshusa closed this Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @paulrouget @aneeshusa
You can’t perform that action at this time.