Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive.extracted does not set excutable bits on NDK files during unzip #538

Closed
larsbergstrom opened this issue Nov 17, 2016 · 3 comments
Closed

Comments

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Nov 17, 2016

This should be fixed in 2015.5.4/2015.8.0:
saltstack/salt#23822

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Dec 7, 2016

I have not yet investigated, but note that Salt 2016.11 has apparently overhauled archive.extracted significantly: https://docs.saltstack.com/en/latest/topics/releases/2016.11.0.html#improved-archive-extraction-support

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Dec 8, 2016

Looking at the docs for archive.extracted in 2016.11, it appears this is due to an upstream Python bug in the zipfile module. This has been worked around by default in 2016.11; however, there appears to be no way to cause archive.extracted to fall back to the native unzip binary in 2016.3, so in the meantime we should go back to a combination of file.managed and cmd.run.

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented May 11, 2017

In #639, I backported a fixed version of the archive.extracted module which includes a fix for this, and #641 tracks adding a test for this. Closing.

@aneeshusa aneeshusa closed this May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.