Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload_nightly.sh: git error #575

Closed
paulrouget opened this issue Jan 9, 2017 · 1 comment
Closed

upload_nightly.sh: git error #575

paulrouget opened this issue Jan 9, 2017 · 1 comment
Labels
C-has open PR

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jan 9, 2017

See: http://build.servo.org/builders/mac-nightly/builds/200/steps/shell__2/logs/stdio

I requires a valid email address, and servo@servo-mac2.(none) is not.

I see 3 options:

  • set the domain name of the machine then it doesn't return (none)
  • set an email address under common/init.sls. Would it work to just add a email field under servo:user.present:?
  • user --author when commiting

/cc @aneeshusa
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Jan 9, 2017

IMO option 3 is best; I'm thinking 'Tom Servo <servo@servo.org>' as the author.

We should also be configuring the domain name on the builders, but Salting the macOS machines is currently broken.
@paulrouget paulrouget mentioned this issue Jan 10, 2017
Merged
bors-servo added a commit to servo/servo that referenced this issue Jan 10, 2017
@bors-servo
Auto merge of #14935 - paulrouget:gitAuthor, r=aneeshusa
Loading status checks…
124301c 
Add git author

fix servo/saltfs#575

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14935)
<!-- Reviewable:end -->
@aneeshusa aneeshusa mentioned this issue Jan 13, 2017
Merged
3 of 5 tasks complete
bors-servo added a commit to servo/servo that referenced this issue Jan 13, 2017
@bors-servo
Auto merge of #15005 - aneeshusa:fix-git-author-setting-for-brew-uplo…
Loading status checks…
dc93a72 
…ad, r=jdm

Fix git author setting for brew upload

<!-- Please describe your changes on the following line: -->

The fix from #14935 wasn't quite right.

cc @paulrouget

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/saltfs#575 properly (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they should be tested by running the mac-nightly builder

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15005)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 4, 2017
@paulrouget
servo: Merge #14935 - Add git author (from paulrouget:gitAuthor); r=a…
b252a11 
…neeshusa

fix servo/saltfs#575

Source-Repo: https://github.com/servo/servo
Source-Revision: 124301cf484818a87ab0b3e0c4ef34645be66174
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 4, 2017
@aneeshusa
servo: Merge #15005 - Fix git author setting for brew upload (from an…
4a4f050 
…eeshusa:fix-git-author-setting-for-brew-upload); r=jdm

<!-- Please describe your changes on the following line: -->

The fix from #14935 wasn't quite right.

cc @paulrouget

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/saltfs#575 properly (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they should be tested by running the mac-nightly builder

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dc93a72997aefaeb04cdc058b01fdd2eb14cef8f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #14935 - Add git author (from paulrouget:gitAuthor); r=a…
817852c 
…neeshusa

fix servo/saltfs#575

Source-Repo: https://github.com/servo/servo
Source-Revision: 124301cf484818a87ab0b3e0c4ef34645be66174

UltraBlame original commit: bb9ad8c041cdb99b468a1f0661353aa04cce711e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #15005 - Fix git author setting for brew upload (from an…
4509f2b 
…eeshusa:fix-git-author-setting-for-brew-upload); r=jdm

<!-- Please describe your changes on the following line: -->

The fix from #14935 wasn't quite right.

cc paulrouget

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/saltfs#575 properly (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they should be tested by running the mac-nightly builder

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dc93a72997aefaeb04cdc058b01fdd2eb14cef8f

UltraBlame original commit: c887afc07880d2d532fdbce7c9021ec3138074a9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #14935 - Add git author (from paulrouget:gitAuthor); r=a…
1ec2bba 
…neeshusa

fix servo/saltfs#575

Source-Repo: https://github.com/servo/servo
Source-Revision: 124301cf484818a87ab0b3e0c4ef34645be66174

UltraBlame original commit: bb9ad8c041cdb99b468a1f0661353aa04cce711e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #15005 - Fix git author setting for brew upload (from an…
d5fc722 
…eeshusa:fix-git-author-setting-for-brew-upload); r=jdm

<!-- Please describe your changes on the following line: -->

The fix from #14935 wasn't quite right.

cc paulrouget

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/saltfs#575 properly (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they should be tested by running the mac-nightly builder

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dc93a72997aefaeb04cdc058b01fdd2eb14cef8f

UltraBlame original commit: c887afc07880d2d532fdbce7c9021ec3138074a9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #14935 - Add git author (from paulrouget:gitAuthor); r=a…
572f19a 
…neeshusa

fix servo/saltfs#575

Source-Repo: https://github.com/servo/servo
Source-Revision: 124301cf484818a87ab0b3e0c4ef34645be66174

UltraBlame original commit: bb9ad8c041cdb99b468a1f0661353aa04cce711e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #15005 - Fix git author setting for brew upload (from an…
fcc2733 
…eeshusa:fix-git-author-setting-for-brew-upload); r=jdm

<!-- Please describe your changes on the following line: -->

The fix from #14935 wasn't quite right.

cc paulrouget

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/saltfs#575 properly (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they should be tested by running the mac-nightly builder

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dc93a72997aefaeb04cdc058b01fdd2eb14cef8f

UltraBlame original commit: c887afc07880d2d532fdbce7c9021ec3138074a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-has open PR
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add git author
Fix git author setting for brew upload
2 participants
@paulrouget @aneeshusa
You can’t perform that action at this time.