Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_user_data is silly #99

Closed
Ms2ger opened this issue Aug 27, 2015 · 3 comments
Closed

make_user_data is silly #99

Ms2ger opened this issue Aug 27, 2015 · 3 comments

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 27, 2015

Could use """ """-style strings.
@rilut
Copy link
Contributor

@rilut rilut commented Nov 20, 2015

@Ms2ger do this need help? May I do it?
@Ms2ger
Copy link
Contributor Author

@Ms2ger Ms2ger commented Nov 20, 2015

Go for it! The code is at

saltfs/buildbot/master/master.cfg

Line 35 in 54a2312

def make_user_data(s):
; it should be a single multiline string, using python's string formatting (%s) to fill in the keys.
@rilut rilut mentioned this issue Nov 20, 2015
Merged
bors-servo added a commit that referenced this issue Nov 20, 2015
@bors-servo
Auto merge of #164 - rilut:patch-1, r=Manishearth
Loading status checks…
5009024 
Convert list of strings in master.cfg to multiline strings

(As per #99)
Is this styling acceptable?
Thanks.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/164)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Feb 21, 2016

This can be closed since #164 is merged.
@KiChjang KiChjang closed this Feb 21, 2016
Manishearth pushed a commit that referenced this issue Mar 9, 2016
@barosl
Retrieve head SHA manually if it is invalid
7a35fde 
Sometimes, GitHub sends the head SHA of a PR as 0000000 through the
webhook. This is called a "null commit", and seems to happen when GitHub
internally encounters a race condition. Last time, it happened when
squashing commits in a PR. In this case, we just try to retrieve the
head SHA manually.

Fixes #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@Ms2ger @rilut @aneeshusa @KiChjang
You can’t perform that action at this time.