Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to supported salt 2019.2.5 release. #1004

Merged
merged 6 commits into from Aug 7, 2020
Merged

Conversation

@jdm
Copy link
Member

jdm commented Aug 4, 2020

Fixes #1003.

@jdm
Copy link
Member Author

jdm commented Aug 4, 2020

My plan is to get TravisCI working, then upgrade the actual CI machine, then merge.

@jdm jdm mentioned this pull request Aug 4, 2020
@jdm jdm force-pushed the jdm:saltchange branch 2 times, most recently from ff85447 to 0906a30 Aug 4, 2020
@jdm
Copy link
Member Author

jdm commented Aug 4, 2020

Oh, yikes, I suddenly realize why the salt_from_scratch workflow is broken - it takes the current master branch of the repository and uses that to run the install_salt.sh script, which means it's getting the old broken URL, and explains why none of my changes to install_salt.sh seemed to make a difference.

@jdm jdm force-pushed the jdm:saltchange branch from c6b4073 to 7bb48c2 Aug 7, 2020
@jdm jdm marked this pull request as ready for review Aug 7, 2020
@jdm jdm force-pushed the jdm:saltchange branch from 7bb48c2 to 9d085d7 Aug 7, 2020
@jdm jdm force-pushed the jdm:saltchange branch from 9d085d7 to f9ffb3b Aug 7, 2020
@jdm jdm force-pushed the jdm:saltchange branch from f9ffb3b to c8ec29e Aug 7, 2020
@jdm
Copy link
Member Author

jdm commented Aug 7, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

📌 Commit 7eba53b has been approved by jdm

bors-servo added a commit that referenced this pull request Aug 7, 2020
Update CI to supported salt 2019.2.5 release.

Fixes #1003.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

Testing commit 7eba53b with merge fcb72e9...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

💔 Test failed - checks-travis

@jdm jdm force-pushed the jdm:saltchange branch from 7eba53b to 2508b2d Aug 7, 2020
@jdm
Copy link
Member Author

jdm commented Aug 7, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

📌 Commit 2508b2d has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

Testing commit 2508b2d with merge eeced29...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

☀️ Test successful - checks-travis
Approved by: jdm
Pushing eeced29 to master...

@bors-servo bors-servo merged commit eeced29 into servo:master Aug 7, 2020
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Failed
Details
homu Test successful
Details
@jdm jdm removed the S-needs-deploy label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.