Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run WPT tests in debug mode #107

Merged
merged 1 commit into from Sep 15, 2015
Merged

Run WPT tests in debug mode #107

merged 1 commit into from Sep 15, 2015

Conversation

@nox
Copy link
Member

nox commented Aug 31, 2015

This lets us use debug_assert!() in Servo. Tests should be run fast enough now that Servo improved.

Review on Reviewable
@nox nox mentioned this pull request Aug 31, 2015
Closed
@Manishearth
Copy link
Member

Manishearth commented Aug 31, 2015

You're adding steps to the release builders; they'll build Servo in release, and then build it again in debug to make wpt work. Not what we want 😄
@nox
Copy link
Member Author

nox commented Aug 31, 2015

Oh, I need to build debug too I guess?
@nox
Copy link
Member Author

nox commented Aug 31, 2015

Isn't the configuration a mess? I think linux_dev_factory and mac_dev_ref_unit_factory are defined twice.
@metajack
Copy link
Contributor

metajack commented Aug 31, 2015

If you want to switch to dev builds, then you should also rename the factories to match. Calling it linux_rel_factory when it builds dev is not the best.

Also, running wpt in debug mode when everything is compiled in release mode will about double our compile times (since it will have to do it twice).

Probably we should switch to running everything in debug. Later we can add new slaves and expand to cover release mode again.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2015

☔ The latest upstream changes (presumably #110) made this pull request unmergeable. Please resolve the merge conflicts.
@nox nox force-pushed the nox:test-wpt-debug branch from 11e1b16 to 3a3b520 Sep 14, 2015
@nox
Copy link
Member Author

nox commented Sep 14, 2015

Rebased and amended, I also renamed the factories and builders accordingly.
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 14, 2015

How about the CSS tests? Did they improve as well?
@nox
Copy link
Member Author

nox commented Sep 14, 2015

@Ms2ger I have absolutely no idea. In doubt, I didn't change it.
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 14, 2015

Except you did on Linux
@nox
Copy link
Member Author

nox commented Sep 14, 2015

I have no idea what you mean. Where did I change test-css?
@nox
Copy link
Member Author

nox commented Sep 14, 2015

Oh right, it's right in the middle of it!
@nox
Copy link
Member Author

nox commented Sep 14, 2015

So I guess I need to either change the other tests to stay consistent, or to move CSS tests on Linux in a separate factory?
@metajack
Copy link
Contributor

metajack commented Sep 14, 2015

Reviewed 2 of 2 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@metajack
Copy link
Contributor

metajack commented Sep 14, 2015

You should change the mac-rel-css factory to mac-dev-css. That will make everything consistent. r=me with that change.
@nox nox force-pushed the nox:test-wpt-debug branch from 3a3b520 to a71e262 Sep 15, 2015
@nox
Run WPT tests in debug mode
Loading status checks…
0e98538 
This lets us use debug_assert!() in Servo. Tests should be run fast enough
now that Servo improved.
@nox nox force-pushed the nox:test-wpt-debug branch from a71e262 to 0e98538 Sep 15, 2015
@nox
Copy link
Member Author

nox commented Sep 15, 2015

@bors-servo r=jack
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

📌 Commit 0e98538 has been approved by jack
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

⌛ Testing commit 0e98538 with merge daeaeed...
bors-servo pushed a commit that referenced this pull request Sep 15, 2015
bors-servo
Auto merge of #107 - nox:test-wpt-debug, r=jack
Loading status checks…
daeaeed 
Run WPT tests in debug mode

This lets us use debug_assert!() in Servo. Tests should be run fast enough now that Servo improved.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/107)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 0e98538 into servo:master Sep 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Sep 15, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @Manishearth @metajack @bors-servo @Ms2ger
You can’t perform that action at this time.