Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upiptables rules for servo-master host #108
Conversation
|
We'll need to set up static IPs for the EC2 slaves I guess and we'll have to use those IPs here. Reviewed 1 of 1 files at r1. buildbot-master.sls, line 112 [r1] (raw file): Comments from the review on Reviewable.io |
|
@metajack Compared to leaving the ports open to the world or opening the ports to anyone in our EC2 region, setting up elastic IPs does look like the best option. |
|
|
| # doesn't seem like the right way. | ||
| {% for minion in '208.52.161.130', '208.52.161.128', '63.135.170.19', | ||
| '208.52.170.250', '66.228.48.56', '173.255.201.95', '45.79.167.177', | ||
| '72.14.176.110','96.126.114.185', '0.0.0.0' %} |
This comment has been minimized.
This comment has been minimized.
claudijd
Mar 18, 2016
Just an FYI here, but having '0.0.0.0' in the list I would suspect has an ANY effect, which makes the other IPs redundant.
7320ea0
to
37d1576
edunham commentedSep 1, 2015
This opens all of the ports currently available on servo-master, which is both saltmaster and buildmaster.
The only other ports currently in use on the master are for dhclient, which is unnecessary since it has a static IP address.
It seems like Salt should have a better way to get minion IPs for line 112, but some searching revealed conflicting advice, so I figured it would be more efficient to just consult the PR's reviewer. I got the list from https://github.com/servo/servo/wiki/Buildbot-administration .
I checked the iptables state source and it looks like rules are only saved if they do not match an existing rule, so they won't get rewritten on each run.