Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functions in master.cfg to share code between factory definitions. #110

Merged
merged 3 commits into from Sep 2, 2015
Merged

Use functions in master.cfg to share code between factory definitions. #110

merged 3 commits into from Sep 2, 2015
+109 −139

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 2, 2015

Review on Reviewable
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 2, 2015

Tested in prod.
@metajack
Copy link
Contributor

metajack commented Sep 2, 2015

r=me if you fix the typo in the first commit message.

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
Ms2ger added 3 commits Sep 2, 2015
@Ms2ger
Introduce a create_factory function in master.cfg.
2f2a30f
@Ms2ger
Introduce create_cargo_factory to share code for the linux and mac ca…
a1db423 
…rgo builders.
@Ms2ger
Introduce create_servo_factory to share code for the Servo builders.
Loading status checks…
fc8ba1a
@Ms2ger Ms2ger force-pushed the create_factory branch from 7f2ca0d to fc8ba1a Sep 2, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 2, 2015

@bors-servo r=metajeck
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2015

📌 Commit fc8ba1a has been approved by metajeck
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2015

⌛ Testing commit fc8ba1a with merge be53ec0...
bors-servo pushed a commit that referenced this pull request Sep 2, 2015
bors-servo
Auto merge of #110 - servo:create_factory, r=metajeck
Loading status checks…
be53ec0 
Use functions in master.cfg to share code between factory definitions.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/110)
<!-- Reviewable:end -->
@Ms2ger Ms2ger closed this Sep 2, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 2, 2015

@bors-servo r=metajack
@Ms2ger Ms2ger reopened this Sep 2, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2015

⌛ Testing commit fc8ba1a with merge e614e8d...
bors-servo pushed a commit that referenced this pull request Sep 2, 2015
bors-servo
Auto merge of #110 - servo:create_factory, r=metajeck
Loading status checks…
e614e8d 
Use functions in master.cfg to share code between factory definitions.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/110)
<!-- Reviewable:end -->
@metajack
Copy link
Contributor

metajack commented Sep 2, 2015

Wait, bors-servo accepted a typo of my name??
@metajack
Copy link
Contributor

metajack commented Sep 2, 2015

I guess if you are a reviewer it doesn't care about what's after r=.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit fc8ba1a into master Sep 2, 2015
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 2, 2015
Merged
@SimonSapin SimonSapin deleted the create_factory branch Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Ms2ger @metajack @bors-servo
You can’t perform that action at this time.