Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install msttcorefonts on Linux buildbot machines #111

Merged
merged 1 commit into from Sep 3, 2015
Merged

Install msttcorefonts on Linux buildbot machines #111

merged 1 commit into from Sep 3, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 3, 2015

Some of the CSS tests depend on these fonts.

Review on Reviewable
@mbrubeck
Install msttcorefonts on Linux buildbot machines
Loading status checks…
1300352 
Some of the CSS tests depend on these fonts.
@mbrubeck mbrubeck mentioned this pull request Sep 3, 2015
Merged
@metajack
Copy link
Contributor

metajack commented Sep 3, 2015

@bors-servo r+

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2015

📌 Commit 1300352 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2015

⌛ Testing commit 1300352 with merge 4fa4a0b...
bors-servo pushed a commit that referenced this pull request Sep 3, 2015
bors-servo
Auto merge of #111 - mbrubeck:msttcorefonts, r=metajack
Loading status checks…
4fa4a0b 
Install msttcorefonts on Linux buildbot machines

Some of the CSS tests depend on these fonts.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/111)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 1300352 into servo:master Sep 3, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
mbrubeck added a commit to mbrubeck/servo that referenced this pull request Sep 3, 2015
@mbrubeck
Update font test metadata
f47148d 
These fonts should pass when msttcorefonts is installed (servo/saltfs#111).
@mbrubeck mbrubeck mentioned this pull request Sep 3, 2015
Closed
@Manishearth
Copy link
Member

Manishearth commented Sep 3, 2015

Does this work? msttcorefonts has a curses UI you have to click through while installing; not sure if a vanilla apt-get will work. IIRC when we used to use Travis it needed to be installed using a separate command.
@metajack
Copy link
Contributor

metajack commented Sep 3, 2015

It certainly seemed to install it on several of the machines. Still testing though.
@metajack
Copy link
Contributor

metajack commented Sep 3, 2015

@Manishearth was right. Some extra work was needed: #112
@metajack metajack mentioned this pull request Sep 14, 2015
Closed
Manishearth pushed a commit that referenced this pull request Mar 9, 2016
@barosl
Merge pull request #111 from Manishearth/delegate
0182354 
Add delegate powers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mbrubeck @metajack @bors-servo @Manishearth
You can’t perform that action at this time.