Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd headless build env var to servo-linux-2 builder. #12
Conversation
|
I haven't tested this, but it seems a simple enough change. Is it possible to test buildbot changes before pushing them? Ideally this could be done simply by passing --features=headless to the ./mach build command. However, this is a chicken and egg problem, since cargo will then fail until it gets the PR which includes the new headless feature. Doing it this way should mean we can update saltfs, and then add a PR which has the headless feature, and reads the env var inside mach to set up the headless build. Once this all settles, we could change to using the method above if we wanted to. |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on efde73c
Jan 22, 2015
|
r+ |
larsbergstrom
added a commit
that referenced
this pull request
Jan 22, 2015
Add headless build env var to servo-linux-2 builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJan 22, 2015
No description provided.