Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd service_identity module #132
Merged
Conversation
Squashes the following warning when starting Buildbot: 2015-10-22 19:41:50+0000 [-] /usr/local/lib/python2.7/dist-packages/twisted/internet/_sslverify.py:184: exceptions.UserWarning: You do not have the service_identity module installed. Please install it from <https://pypi.python.org/pypi/service_identity>. Without the service_identity module and a recent enough pyOpenSSL tosupport it, Twisted can perform only rudimentary TLS client hostnameverification. Many valid certificate/hostname mappings may be rejected.
|
@bors-servo r+ Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
bors-servo
pushed a commit
that referenced
this pull request
Oct 22, 2015
Add service_identity module Squashes the following warning when starting Buildbot: 2015-10-22 19:41:50+0000 [-] /usr/local/lib/python2.7/dist-packages/twisted/internet/_sslverify.py:184: exceptions.UserWarning: You do not have the service_identity module installed. Please install it from <https://pypi.python.org/pypi/service_identity>. Without the service_identity module and a recent enough pyOpenSSL tosupport it, Twisted can perform only rudimentary TLS client hostnameverification. Many valid certificate/hostname mappings may be rejected. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/132) <!-- Reviewable:end -->
|
|
aneeshusa
added a commit
to aneeshusa/servo-saltfs
that referenced
this pull request
Oct 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedOct 22, 2015
Squashes the following warning when starting Buildbot:
2015-10-22 19:41:50+0000 [-]
/usr/local/lib/python2.7/dist-packages/twisted/internet/_sslverify.py:184:
exceptions.UserWarning: You do not have the service_identity module installed.
Please install it from https://pypi.python.org/pypi/service_identity.
Without the service_identity module and a recent enough pyOpenSSL tosupport
it, Twisted can perform only rudimentary TLS client hostnameverification.
Many valid certificate/hostname mappings may be rejected.