Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install deps to fix CI build #138

Closed
wants to merge 1 commit into from
Closed

Explicitly install deps to fix CI build #138

wants to merge 1 commit into from

Conversation

@edunham
Copy link
Contributor

edunham commented Oct 27, 2015

The logs at https://travis-ci.org/servo/saltfs/jobs/87759990, specifically

The following packages have unmet dependencies:
 salt-minion : Depends: salt-common (= 2015.5.3+ds-1precise2) but it is not going to be installed
               Depends: python-zmq (>= 13.0.0) but it is not going to be installed
               Recommends: dmidecode but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
The command ".travis/install_salt" failed and exited with 100 during .
Your build has been stopped.

make me think that having those packages available on the system will allow the
build to continue. Maybe.

Review on Reviewable
@edunham
Explicitly install deps to fix CI build
Loading status checks…
337dddc 
The logs at https://travis-ci.org/servo/saltfs/jobs/87759990, specifically

    The following packages have unmet dependencies:
     salt-minion : Depends: salt-common (= 2015.5.3+ds-1precise2) but it is not going to be installed
                   Depends: python-zmq (>= 13.0.0) but it is not going to be installed
                   Recommends: dmidecode but it is not going to be installed
    E: Unable to correct problems, you have held broken packages.
    The command ".travis/install_salt" failed and exited with 100 during .
    Your build has been stopped.

make me think that having those packages available on the system will allow the
build to continue. Maybe.
@metajack
Copy link
Contributor

metajack commented Oct 27, 2015

@bors-servo r+

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2015

📌 Commit 337dddc has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2015

⌛ Testing commit 337dddc with merge 1d9ea28...
bors-servo added a commit that referenced this pull request Oct 27, 2015
@bors-servo
Auto merge of #138 - edunham:fix-travis, r=metajack
Loading status checks…
1d9ea28 
Explicitly install deps to fix CI build

The logs at https://travis-ci.org/servo/saltfs/jobs/87759990, specifically

    The following packages have unmet dependencies:
     salt-minion : Depends: salt-common (= 2015.5.3+ds-1precise2) but it is not going to be installed
                   Depends: python-zmq (>= 13.0.0) but it is not going to be installed
                   Recommends: dmidecode but it is not going to be installed
    E: Unable to correct problems, you have held broken packages.
    The command ".travis/install_salt" failed and exited with 100 during .
    Your build has been stopped.

make me think that having those packages available on the system will allow the
build to continue. Maybe.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/138)
<!-- Reviewable:end -->
@edunham edunham closed this Oct 27, 2015
@metajack
Copy link
Contributor

metajack commented Oct 27, 2015

?
@edunham edunham reopened this Oct 27, 2015
@edunham
Copy link
Contributor Author

edunham commented Oct 27, 2015

I briefly forgot how to Bors and mistook the auto merge commit for an actual merge commit. Sorry.
@aneeshusa
Copy link
Member

aneeshusa commented Oct 27, 2015

I'm working on it, sorry! I don't use Ubuntu normally and just got it working in Vagrant, so hopefully it works now on Travis as well.
@edunham
Copy link
Contributor Author

edunham commented Oct 27, 2015

@aneeshusa Was this the correct PR for that comment? I don't think you have anything to apologize for here.
@aneeshusa
Copy link
Member

aneeshusa commented Oct 27, 2015

I could have worded that comment better, just wanted to let you know I was aware of and actively working on the dependencies not installing correctly in #97.
@edunham
Copy link
Contributor Author

edunham commented Oct 27, 2015

oh, that makes sense! I'm patching up the current CI build for this because we just turned on https://nightli.es/ for a bunch of Servo's repos. Feel free to revert this when #97 lands if you need to :)
@aneeshusa
Copy link
Member

aneeshusa commented Oct 27, 2015

The logs you mentioned in the first comment are actually from me working on #97; I believe master should be OK and building correctly right now.
@edunham
Copy link
Contributor Author

edunham commented Oct 27, 2015

Ah, cool. Then I'll leave this alone :)
@edunham edunham closed this Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@edunham @metajack @bors-servo @aneeshusa
You can’t perform that action at this time.