Explicitly install deps to fix CI build#138
Conversation
The logs at https://travis-ci.org/servo/saltfs/jobs/87759990, specifically The following packages have unmet dependencies: salt-minion : Depends: salt-common (= 2015.5.3+ds-1precise2) but it is not going to be installed Depends: python-zmq (>= 13.0.0) but it is not going to be installed Recommends: dmidecode but it is not going to be installed E: Unable to correct problems, you have held broken packages. The command ".travis/install_salt" failed and exited with 100 during . Your build has been stopped. make me think that having those packages available on the system will allow the build to continue. Maybe.
|
@bors-servo r+ Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
📌 Commit 337dddc has been approved by |
Explicitly install deps to fix CI build The logs at https://travis-ci.org/servo/saltfs/jobs/87759990, specifically The following packages have unmet dependencies: salt-minion : Depends: salt-common (= 2015.5.3+ds-1precise2) but it is not going to be installed Depends: python-zmq (>= 13.0.0) but it is not going to be installed Recommends: dmidecode but it is not going to be installed E: Unable to correct problems, you have held broken packages. The command ".travis/install_salt" failed and exited with 100 during . Your build has been stopped. make me think that having those packages available on the system will allow the build to continue. Maybe. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/138) <!-- Reviewable:end -->
|
? |
|
I briefly forgot how to Bors and mistook the auto merge commit for an actual merge commit. Sorry. |
|
I'm working on it, sorry! I don't use Ubuntu normally and just got it working in Vagrant, so hopefully it works now on Travis as well. |
|
@aneeshusa Was this the correct PR for that comment? I don't think you have anything to apologize for here. |
|
I could have worded that comment better, just wanted to let you know I was aware of and actively working on the dependencies not installing correctly in #97. |
|
oh, that makes sense! I'm patching up the current CI build for this because we just turned on https://nightli.es/ for a bunch of Servo's repos. Feel free to revert this when #97 lands if you need to :) |
|
The logs you mentioned in the first comment are actually from me working on #97; I believe master should be OK and building correctly right now. |
|
Ah, cool. Then I'll leave this alone :) |
4 participants
The logs at https://travis-ci.org/servo/saltfs/jobs/87759990, specifically
make me think that having those packages available on the system will allow the
build to continue. Maybe.