Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'try' privileges #141

Merged
merged 3 commits into from Oct 30, 2015
Merged

Add 'try' privileges #141

merged 3 commits into from Oct 30, 2015

Conversation

@Manishearth
Copy link
Member

Manishearth commented Oct 30, 2015

Don't merge yet.

This needs:

sudo apt-get install python3.4 python3-pip
pip3 install virtualenv

to be run as well. Not sure how to make these concrete dependencies because of the pip3

Review on Reviewable

Manishearth added 3 commits Oct 27, 2015
@ManishBot
Copy link
Contributor

ManishBot commented Oct 30, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

Trying commit 11547ad with merge 99a1eb2...

bors-servo added a commit that referenced this pull request Oct 30, 2015
Add 'try' privileges

Don't merge yet.

This needs:

```
sudo apt-get install python3.4 python3-pip
pip3 install virtualenv
```

to be run as well. Not sure how to make these concrete dependencies because of the `pip3`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/141)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

☀️ Test successful - travis

@ManishBot
Copy link
Contributor

ManishBot commented Oct 30, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

🔑 Insufficient privileges

@ManishBot
Copy link
Contributor

ManishBot commented Oct 30, 2015

😭

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 30, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

📌 Commit 11547ad has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

Testing commit 11547ad with merge e9cf5ab...

bors-servo added a commit that referenced this pull request Oct 30, 2015
Add 'try' privileges

Don't merge yet.

This needs:

```
sudo apt-get install python3.4 python3-pip
pip3 install virtualenv
```

to be run as well. Not sure how to make these concrete dependencies because of the `pip3`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/141)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 30, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 11547ad into master Oct 30, 2015
2 of 3 checks passed
2 of 3 checks passed
homu Testing commit 11547ad with merge e9cf5ab...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Manishearth Manishearth deleted the try branch Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.