Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Android states on Travis #145

Merged
merged 3 commits into from Nov 3, 2015

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Nov 1, 2015

The larger memory limits on the Trusty beta will
hopefully make these less flaky.

Review on Reviewable

The larger memory limits on the Trusty beta will
hopefully make these less flaky.
@Manishearth
Copy link
Member

Manishearth commented Nov 1, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2015

📌 Commit f4a3e8a has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2015

Testing commit f4a3e8a with merge b69e52e...

bors-servo added a commit that referenced this pull request Nov 1, 2015
Re-enable Android states on Travis

The larger memory limits on the Trusty beta will
hopefully make these less flaky.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/145)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member Author

aneeshusa commented Nov 1, 2015

I'd recommend trying this build a few times before merging to make sure it's not flaky - I know there have been problems in the past.

@Manishearth
Copy link
Member

Manishearth commented Nov 1, 2015

@bors-servo r- force

@Manishearth Manishearth closed this Nov 1, 2015
@Manishearth Manishearth reopened this Nov 1, 2015
@Manishearth
Copy link
Member

Manishearth commented Nov 1, 2015

@Manishearth
Copy link
Member

Manishearth commented Nov 1, 2015

@bors-servo force

@Manishearth Manishearth closed this Nov 1, 2015
@Manishearth
Copy link
Member

Manishearth commented Nov 1, 2015

Keeping it closed till the travis build passes.

@aneeshusa
Copy link
Member Author

aneeshusa commented Nov 1, 2015

Ok, thanks. Looks like some of the package names may have changed, I'll take a look at it now.

@Manishearth
Copy link
Member

Manishearth commented Nov 1, 2015

Cool

@Manishearth Manishearth reopened this Nov 1, 2015
@Manishearth Manishearth closed this Nov 1, 2015
@Manishearth Manishearth reopened this Nov 1, 2015
Some of the dependencies for Android require 32-bit versions
of certain package, so add the architecture and update the package
database (via refresh: True) before installing them.
@aneeshusa
Copy link
Member Author

aneeshusa commented Nov 1, 2015

I fixed the package installation problem, but it looks like it's running into disk space limits.

@aneeshusa
Copy link
Member Author

aneeshusa commented Nov 1, 2015

Do you know which components/versions of the SDK/NDK we need? It looks like it may be possible to selectively download the pieces we need: https://sites.google.com/a/android.com/tools/recent/updatingsdkfromcommand-line

@Manishearth
Copy link
Member

Manishearth commented Nov 1, 2015

Not sure. @larsbergstrom ?

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 1, 2015

Platform tools and API 18 at least (it's hard to tell what it actually installed). I suspect this will take a little bit of trial and error.

The NDK comes as a big blob. you just have to grab & unpack the binary then also install the specific toolkit (use cmdline in https://github.com/servo/servo/wiki/Building-for-Android#set-up-toolchain).

Use --filter to only download and extract necessary SDK components. This
is faster, uses less resources and gets around Travis disk space limits.
Update to latest SDK and NDK versions and use sha512 instead of sha1.
Use archive.extracted for better semantics and concision.
@aneeshusa
Copy link
Member Author

aneeshusa commented Nov 2, 2015

Looks like I got it to build cleanly on Travis! Shame about the build time though.

@Manishearth
Copy link
Member

Manishearth commented Nov 3, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

📌 Commit b80f1bd has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

Testing commit b80f1bd with merge 062a51e...

bors-servo added a commit that referenced this pull request Nov 3, 2015
Re-enable Android states on Travis

The larger memory limits on the Trusty beta will
hopefully make these less flaky.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/145)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit b80f1bd into servo:master Nov 3, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.