Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd release builders #15
Merged
Conversation
Manishearth
pushed a commit
that referenced
this pull request
Mar 9, 2016
The revision property is set to an empty string when the build was initiated by a trigger. As the initial value of merge_sha is also an empty string, an arbitrary PR is mistakenly chosen, leading to a mysterious "test successful" message. We should check if the property is valid before utilising it. Fixes #15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedFeb 24, 2015
Force pushing to the
releasebranch should trigger a buildr? @larsbergstrom
(I am not sure if this will actually work)