Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backticks to style guide #160

Merged
merged 1 commit into from Nov 11, 2015
Merged

Add backticks to style guide #160

merged 1 commit into from Nov 11, 2015

Conversation

@ManishBot
Copy link
Contributor

ManishBot commented Nov 11, 2015

Review on Reviewable
@ManishBot
Add backticks to readme
Loading status checks…
362f5a5
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo r+
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo delegate=ManishBot
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

✌️ @ManishBot can now approve this pull request
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

📌 Commit 362f5a5 has been approved by ManishBot
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

⌛ Testing commit 362f5a5 with merge 67a3ac5...
bors-servo added a commit that referenced this pull request Nov 11, 2015
@bors-servo
Auto merge of #160 - ManishBot:patch-2, r=ManishBot
Loading status checks…
67a3ac5 
Add backticks to style guide

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/160)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo r-
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo delegate-
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo r+
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo delegate
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

✌️ @ManishBot can now approve this pull request
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo rollup
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo delegate-
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo delegate
1 similar comment
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo delegate
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo delegate=manishbot
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

✌️ @ManishBot can now approve this pull request
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo delegate+
1 similar comment
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

✌️ @ManishBot can now approve this pull request
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

✌️ @ManishBot can now approve this pull request
@ManishBot
Copy link
Contributor Author

ManishBot commented Nov 11, 2015

@bors-servo delegate=ManishBot
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

✌️ @ManishBot can now approve this pull request
@Manishearth Manishearth reopened this Nov 11, 2015
@Manishearth Manishearth mentioned this pull request Nov 11, 2015
Merged
@jgraham
Copy link
Contributor

jgraham commented Nov 11, 2015

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@jgraham
Copy link
Contributor

jgraham commented Nov 11, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

📌 Commit 362f5a5 has been approved by jgraham
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

@bors-servo force
@Manishearth
Copy link
Member

Manishearth commented Nov 11, 2015

oh, right, I'd cancelled the build
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

⌛ Testing commit 362f5a5 with merge ec0cb67...
bors-servo added a commit that referenced this pull request Nov 11, 2015
@bors-servo
Auto merge of #160 - ManishBot:patch-2, r=jgraham
Loading status checks…
ec0cb67 
Add backticks to style guide

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/160)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 11, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 362f5a5 into servo:master Nov 11, 2015
2 of 3 checks passed
2 of 3 checks passed
homu Testing commit 362f5a5 with merge ec0cb67...
Details
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bors-servo added a commit that referenced this pull request Nov 11, 2015
@bors-servo
Auto merge of #161 - servo:delegate, r=larsbergstrom
Loading status checks…
d181bb0 
Enable delegation

Already running on the infra.

#160 is an example of it working.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/161)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@ManishBot @Manishearth @bors-servo @jgraham
You can’t perform that action at this time.