New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Salt 2015.5.8 #175

Merged
merged 1 commit into from Dec 15, 2015

Conversation

Projects
None yet
4 participants
@aneeshusa
Member

aneeshusa commented Dec 15, 2015

Also switch to new archive url scheme (introduced with 2015.8.3).
The new archive urls point to a specific Salt version and will not
change over time, allowing for precise version pinning.

Closes #174.

Review on Reviewable

Update to Salt 2015.5.8
Also switch to new archive url scheme (introduced with 2015.8.3).
The new archive urls point to a specific Salt version and will not
change over time, allowing for precise version pinning.

Closes #174.
@metajack

This comment has been minimized.

Contributor

metajack commented Dec 15, 2015

@bors-servo r+


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 15, 2015

📌 Commit 9fccba1 has been approved by metajack

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 15, 2015

⌛️ Testing commit 9fccba1 with merge 74b97bf...

bors-servo added a commit that referenced this pull request Dec 15, 2015

Auto merge of #175 - aneeshusa:update-to-salt-2015.5.8, r=metajack
Update to Salt 2015.5.8

Also switch to new archive url scheme (introduced with 2015.8.3).
The new archive urls point to a specific Salt version and will not
change over time, allowing for precise version pinning.

Closes #174.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/175)
<!-- Reviewable:end -->
@aneeshusa

This comment has been minimized.

Member

aneeshusa commented Dec 15, 2015

Is there a way to get homu to not run the same build twice? It looks like the original PR submission triggered #579, and now homu is running #581, even though nothing has changed in the meantime.

@Manishearth

This comment has been minimized.

Member

Manishearth commented Dec 15, 2015

Not at the moment, no. Though it's not so easy to generalize this, not all projects run the same tests for PRs and for pushes.

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 15, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 9fccba1 into servo:master Dec 15, 2015

3 checks passed

code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@aneeshusa

This comment has been minimized.

Member

aneeshusa commented Dec 15, 2015

Oh, I didn't think of that, that makes sense. These builds don't take too long anyways.

@metajack

This comment has been minimized.

Contributor

metajack commented Dec 15, 2015

I tried to fix this a while back but it's a limitation of travis currently.

@aneeshusa aneeshusa referenced this pull request Dec 15, 2015

Merged

Add waffles to try #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment