Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHack to add more latent builders in case of ill-timed restart #195
Conversation
…estart. Also cleanup list.
|
Aha, this will create more than 2 live instances in the case where there is both a real build and a try build going at the same time. |
|
I'm not a huge fan of this, since it will make the real problem harder to debug and easier to ignore. |
|
@bors-servo r+ Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 12, 2016
Hack to add more latent builders in case of ill-timed restart We should never have more than two active, but when one builder "dies" for w/e reason, for the duration of the buildbot run, the machine will not be restarted. This adds 3, getting us to 5, an arbitrary number that I hope will keep us at our 2 live instances at any point in time until we can either pull the trigger on reserved instances or get better about Graceful Shutdown, etc. Also, removed `servo-linux1`, which is no longer around but was still on the waterfall page. r? @edunham @metajack @Manishearth <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/195) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedJan 12, 2016
We should never have more than two active, but when one builder "dies" for w/e reason, for the duration of the buildbot run, the machine will not be restarted. This adds 3, getting us to 5, an arbitrary number that I hope will keep us at our 2 live instances at any point in time until we can either pull the trigger on reserved instances or get better about Graceful Shutdown, etc.
Also, removed
servo-linux1, which is no longer around but was still on the waterfall page.r? @edunham @metajack @Manishearth