Remove 5-day-old zipped logs from buildslave dirs every night

[edunham]

Low disk space command from https://github.com/servo/servo/wiki/Buildbot-administration#handling-low-disk-space . We should no longer need to escape the semicolon, since Bash eats semicolons but Salt doesn't (right?)

Salt cron syntax from https://docs.saltstack.com/en/latest/ref/states/all/salt.states.cron.html

[emilio]

I think you can do -delete instead of -exec rm {} ; (which may or may not need the semicolon) :P

[edunham]

Yep, that works. Fixed; thanks for catching that.

[aneeshusa]

I'd suggest using a more suggestive id and putting the actual command as the name parameter, like so:

remove-old-build-logs:
  cron.present:
    - name: 'find /home/servo/buildbot/master/*/*.bz2 -mtime +5 -delete'
    - user: root
    - minute: 1 
    - hour: 0

I also recommend quoting complicated commands like these to make it clear that they are strings and avoid ambiguity in parsing, but strictly speaking the quotes are optional.

This makes it easier to see what the state is for and easier to reference it from another state. Here's the Salt documentation about names. Additionally, for the cron states in particular, the state id will become an identifier argument to the state, and using a stable identifier will allow for more robust updates in the future. The link @edunham posted to the Salt docs has more information about this behavior. (FYI, the link you posted is for the latest version of Salt, but we're not running 2015.8 yet; click the "2015.5" button when looking at Salt docs to get the right version.)

[larsbergstrom]

@edunham Can you address this when you get a chance? We hit another out of disk space on buildbot master today :-(

[bors-servo]

☔ The latest upstream changes (presumably #148) made this pull request unmergeable. Please resolve the merge conflicts.

[edunham]

Overwrote old branch with @aneeshusa 's recommended change applied to latest master

[larsbergstrom]

@bors-servo r+

[bors-servo]

📌 Commit b05e418 has been approved by larsbergstrom

[bors-servo]

⌛ Testing commit b05e418 with merge c2c71b6...

[bors-servo]

☀️ Test successful - travis