Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix NDK version path #203
Merged
fix NDK version path #203
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 28, 2016
fix NDK version path r? @metajack @Manishearth We had updated the Salt stuff to install r10e instead of r10c, but not the environment variables. This happens to work on older builders that still had r10c on them. Did not work on servo-head (which is a second reason why android-nightly has been failing). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/203) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedJan 28, 2016
r? @metajack @Manishearth
We had updated the Salt stuff to install r10e instead of r10c, but not the environment variables. This happens to work on older builders that still had r10c on them. Did not work on servo-head (which is a second reason why android-nightly has been failing).