Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added asajeffrey to reviewers. #213

Merged
merged 1 commit into from Feb 4, 2016
Merged

Added asajeffrey to reviewers. #213

merged 1 commit into from Feb 4, 2016

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Feb 4, 2016

As discussed with @metajack.

Review on Reviewable
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 4, 2016

You don't need to be in the try group if you're in the reviewers group.
@asajeffrey
Added asajeffrey to reviewers.
Loading status checks…
ae78100
@asajeffrey asajeffrey force-pushed the asajeffrey:master branch from 3b7586c to ae78100 Feb 4, 2016
@asajeffrey
Copy link
Member Author

asajeffrey commented Feb 4, 2016

Fixed.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 4, 2016

@bors-servo r=metajack
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

📌 Commit ae78100 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit ae78100 with merge de61823...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #213 - asajeffrey:master, r=larsbergstrom
Loading status checks…
de61823 
Added asajeffrey to reviewers.

As discussed with @metajack.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/213)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member

Manishearth commented Feb 4, 2016

🎉
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit ae78100 into servo:master Feb 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@asajeffrey
Copy link
Member Author

asajeffrey commented Feb 4, 2016

Thanks! Er, I guess I have to do some reviewing now...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@asajeffrey @larsbergstrom @bors-servo @Manishearth
You can’t perform that action at this time.