Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLink a newer openssl from homebrew on OS X #218
Merged
Conversation
|
Yeah, it was missing in the travis console for some reason. It appears to have been picked up now. |
aneeshusa
force-pushed the
aneeshusa:link-openssl-on-osx
branch
4 times, most recently
from
414fc30
to
f982a8c
Our OS X builders have administrator as the Homebrew owner, but this is not the case on Travis.
|
I put in a fix for Travis and tested this locally on Note to self: remember to update the wiki to remove the section about openssl on OS X when this is merged. |
|
@bors-servo r+ Thanks for your continued awesome work on our Salt infra! |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 8, 2016
Link a newer openssl from homebrew on OS X This should be manually tested to a) make sure I didn't break the autoconf linkage, and b) to ensure the openssl linkage works properly. Closes #210 (for real this time!) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/218) <!-- Reviewable:end -->
|
|
|
Weird, I didn't get any emails about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedFeb 6, 2016
This should be manually tested to a) make sure I didn't break the autoconf linkage, and b) to ensure the openssl linkage works properly.
Closes #210 (for real this time!)