Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable service autostart on package install #229

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Feb 29, 2016

Debian and its derivatives will autostart services when installing
packages. However, often we need to configure installed software
before it is ready to run, so it's preferable to use Salt states and
requisites to handle package installation or upgrades, configuration
changes and service [re]starting.

Adding a policy-rc.d file with exit code 101 sets a policy which denies
this default behavior. Making this change in the install script also
prevents new builders from attempting to contact the Salt master before
they have been configured properly.

Review on Reviewable

Debian and its derivatives will autostart services when installing
packages. However, often we need to configure installed software
before it is ready to run, so it's preferable to use Salt states and
requisites to handle package installation or upgrades, configuration
changes and service [re]starting.

Adding a policy-rc.d file with exit code 101 sets a policy which denies
this default behavior. Making this change in the install script also
prevents new builders from attempting to contact the Salt master before
they have been configured properly.
@aneeshusa
Copy link
Member Author

aneeshusa commented Feb 29, 2016

@larsbergstrom this should prevent some of those spurious entries in salt-key -L we were discussing in #222.

Reminder to self: update the wiki installation instruction after this lands.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 29, 2016

@bors-servo r+

Thanks - this looks great to me! I think the wiki instruction changes will also be key for OSX, where we have to do a much more manual installation of salt.

@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

📌 Commit 88a9116 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

Testing commit 88a9116 with merge 79515d4...

bors-servo added a commit that referenced this pull request Feb 29, 2016
…nstall, r=larsbergstrom

Disable service autostart on package install

Debian and its derivatives will autostart services when installing
packages. However, often we need to configure installed software
before it is ready to run, so it's preferable to use Salt states and
requisites to handle package installation or upgrades, configuration
changes and service [re]starting.

Adding a policy-rc.d file with exit code 101 sets a policy which denies
this default behavior. Making this change in the install script also
prevents new builders from attempting to contact the Salt master before
they have been configured properly.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/229)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 29, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 88a9116 into servo:master Feb 29, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@aneeshusa
Copy link
Member Author

aneeshusa commented Feb 29, 2016

@larsbergstrom This PR actually only affects the Linux builders, but I've gone some more PRs in the pipeline:)

BTW, I'm testing some things on servo-macpro1 and it seems to be having some networking issues (I'm testing out installing some things through brew). I believe it's not hooked up to buildbot yet and no one else seems to be using it at the moment - is it ok if I try a reboot?

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 29, 2016

@aneeshusa Go right ahead and reboot it!

@mbrubeck was the only other one looking at it, and I don't believe he's actively using it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.