Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't run Travis builds on master #235
Conversation
All commits on master are fast-forwards to merge commits that are created by homu and already tested by Travis, so testing commits on master duplicates the build.
|
@bors-servo r+ |
|
|
…rsbergstrom Don't run Travis builds on master All commits on master are fast-forwards to merge commits that are created by homu and already tested by Travis, so testing commits on master duplicates the build. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/235) <!-- Reviewable:end -->
|
If you look at https://travis-ci.org/servo/saltfs/builds, Travis also seems to run the build on the 'auto' branch twice - i.e., for a PR, it'll run the build on auto (for homu), and then after merging run it on master (which this gets rid of) and again on auto. Do you know why this happens? I'd like to remove the other duplicated build as well, but I don't want to break homu. |
|
|
|
I think that @Manishearth has also been looking at some of the extra builds on auto. IIRC, it had to do with the double-push that homu does (first a force-push to make auto=master, then a push of the additional commit), as otherwise the single-force push will trigger travis but not buildbot. However, my memory may be off... |
|
r- This was tried before and does not do what you want. Here's my email to travis support and their response from July of 2015:
branches:
So unless you have information that this behavior is now fixed, please revert this. |
|
We could make it so that when it's not a pull request and the branch is master, the travis script is a no-op (there are environment variables). Alternatively, turn on homu's exemption feature, which lets us skip build #2 if build #1 has the correct |
|
:( I didn't realize this had already been tried and doesn't work. |
|
No worries. Great minds must think alike :) |
…r, r=metajack Revert "Don't run Travis builds on master" This reverts commit 9cbbbf0. See #235 (comment) for the reasoning on the revert. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/236) <!-- Reviewable:end -->
aneeshusa commentedMar 5, 2016
All commits on master are fast-forwards to merge commits that are
created by homu and already tested by Travis, so testing commits on
master duplicates the build.