Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure Vagrant version is at least 1.8.0 #240
Merged
Conversation
Use the Vagrant.require_version helper documented here: https://www.vagrantup.com/docs/vagrantfile/vagrant_version.html Eliminates issues like #238.
|
Build broke due to timeout issues so I've retried it through Travis |
|
When I try this on Vagrant 1.4.3, I get the error:
In my opinion, forbidding Vagrant versions which sporadically break the build is a better use of our time than fixing each quirk that shows up only in old Vagrants. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 24, 2016
…bergstrom Ensure Vagrant version is at least 1.8.0 Use the Vagrant.require_version helper documented here: https://www.vagrantup.com/docs/vagrantfile/vagrant_version.html Eliminates issues like #238. Heads up: I didn't test this with a Vagrant older than 1.8.0, so I have no idea if this actually works. @larsbergstrom can you test this if possible since you ran into this? I want to make sure this is actually a useful change. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/240) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedMar 8, 2016
Use the Vagrant.require_version helper documented here:
https://www.vagrantup.com/docs/vagrantfile/vagrant_version.html
Eliminates issues like #238.
Heads up: I didn't test this with a Vagrant older than 1.8.0, so I have no idea if this actually works.
@larsbergstrom can you test this if possible since you ran into this?
I want to make sure this is actually a useful change.