Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Vagrant version is at least 1.8.0 #240

Merged
merged 1 commit into from Mar 24, 2016

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Mar 8, 2016

Use the Vagrant.require_version helper documented here:
https://www.vagrantup.com/docs/vagrantfile/vagrant_version.html

Eliminates issues like #238.

Heads up: I didn't test this with a Vagrant older than 1.8.0, so I have no idea if this actually works.
@larsbergstrom can you test this if possible since you ran into this?
I want to make sure this is actually a useful change.

Review on Reviewable

Use the Vagrant.require_version helper documented here:
https://www.vagrantup.com/docs/vagrantfile/vagrant_version.html

Eliminates issues like #238.
@edunham
Copy link
Contributor

edunham commented Mar 22, 2016

Build broke due to timeout issues so I've retried it through Travis

@edunham
Copy link
Contributor

edunham commented Mar 24, 2016

When I try this on Vagrant 1.4.3, I get the error:

Vagrant failed to initialize at a very early stage:

This Vagrant environment has specified that it requires the Vagrant
version to satisfy the following version requirements:

  >= 1.8.0

You are running Vagrant 1.4.3, which does not satisify
these requirements. Please change your Vagrant version or update
the Vagrantfile to allow this Vagrant version. However, be warned
that if the Vagrantfile has specified another version, it probably has
good reason to do so, and changing that may cause the environment to
not function properly.

In my opinion, forbidding Vagrant versions which sporadically break the build is a better use of our time than fixing each quirk that shows up only in old Vagrants.

r? @larsbergstrom

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 24, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

📌 Commit 77a7a7a has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

Testing commit 77a7a7a with merge c1d73d7...

bors-servo added a commit that referenced this pull request Mar 24, 2016
…bergstrom

Ensure Vagrant version is at least 1.8.0

Use the Vagrant.require_version helper documented here:
https://www.vagrantup.com/docs/vagrantfile/vagrant_version.html

Eliminates issues like #238.

Heads up: I didn't test this with a Vagrant older than 1.8.0, so I have no idea if this actually works.
@larsbergstrom can you test this if possible since you ran into this?
I want to make sure this is actually a useful change.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/240)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 77a7a7a into servo:master Mar 24, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.