Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd aneeshusa as a reviewer #245
Merged
Conversation
|
@bors-servo r+ wooo |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 12, 2016
Add aneeshusa as a reviewer r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/245) <!-- Reviewable:end -->
|
|
|
@larsbergstrom When you asked me to review the ARM PR I was wondering when you'd figure this out |
|
@aneeshusa While I'd like to claim it was planned, that is how our model (https://github.com/servo/servo/wiki/Governance#reviewer-privileges) is supposed to work :-) That is, assign a review, review the review, and then grant reviewer privileges. Thanks again for all your help, contributions, and reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedMar 11, 2016
r? @Manishearth
This change is