Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Vagrant to set the VM hostname #248
Conversation
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
|
This has the benefit that Salt will automatically pick up on the hostname and use it as the minion id, removing the need to manually pass the minion ID in the Vagrantfile and when debugging inside the VM.
aneeshusa
force-pushed the
aneeshusa:set-vagrant-hostname
branch
from
01e8aa0
to
b4e43a0
|
Vagrant 1.8.5 will pass |
|
|
|
I need to make another vagrant PR to add |
The hacky `minion_id` method to pass `file-root` and `pillar-root` to `salt-call` does not work since Vagrant 1.8.3. If Vagrant accepts hashicorp/vagrant#7836 , this PR will use the new argument. It also sets the hostname using the appropriate option, superseeding servo#248. DO NOT MERGE until Vagrant accepts the PR, and releases a new version.
|
Happily, this is no longer blocked as the Vagrant upstream feature this depended on has been merged and released as part of Vagrant 2.0: https://github.com/mitchellh/vagrant/blob/a124f6635844848f4369e620e1607701d22ddcb9/CHANGELOG.md. I will try to update this PR soon. |
aneeshusa commentedMar 14, 2016
This has the benefit that Salt will automatically pick up on the
hostname and use it as the minion id, removing the need to manually
pass the minion ID in the Vagrantfile and when debugging inside the VM.
This is blocked on hashicorp/vagrant#7137 landing
and getting released in a new Vagrant version.
Reminder to self: update the wiki when this lands.
This change is