Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCall a new script to check dynamic symbols in Android binary #8351 #249
Conversation
| @@ -219,6 +219,7 @@ android_factory = create_servo_factory([ | |||
| steps.Compile(command=["./mach", "build", "--android", "--dev"], env=android_compile_env), | |||
| steps.ShellCommand(command=["bash", "./etc/ci/lockfile_changed.sh"], env=android_compile_env), | |||
| steps.ShellCommand(command=["bash", "./etc/ci/manifest_changed.sh"], env=android_compile_env), | |||
| steps.ShellCommand(command=["python", "./etc/ci/check_dynamic_symbols.py"], env=android_compile_env), | |||
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 19, 2016
Add a script to CI to check dynamic symbols in Android binary #8351 Tries to fix #8351. This is meaningful only with the PR to servo/saltfs Cross PR: servo/saltfs#249 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9981) <!-- Reviewable:end -->
aneeshusa
added a commit
to aneeshusa/servo
that referenced
this pull request
Mar 20, 2016
Make the script that checks for undefined Android symbols compatible with both Python 2 and Python 3, to allow for future updates to the default system Python on our build machines. I'd like to land this before servo/saltfs#249. We currently use Ubuntu 14.04 (an LTS release); Ubuntu is aiming for Python 3 as the default Python in the next LTS release, 16.04, and I'd like to have any scripts be ready for the transition.
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 21, 2016
…python3-compatible, r=Ms2ger Add Python 3 compatibility to Android symbol checker Make the script that checks for undefined Android symbols compatible with both Python 2 and Python 3, to allow for future updates to the default system Python on our build machines. I'd like to land this before servo/saltfs#249. We currently use Ubuntu 14.04 (an LTS release); Ubuntu is aiming for Python 3 as the default Python in the next LTS release, 16.04, and I'd like to have any scripts be ready for the transition. Do we have a Python 2/3 compatibility policy? cc @cengizIO @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10097) <!-- Reviewable:end -->
|
@bors-servo r+ Thanks for the PR, @cengizIO! |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 22, 2016
Call a new script to check dynamic symbols in Android binary #8351 Tries to fix #8351. This is meaningful only with the PR to servo/servo Cross PR: servo/servo#9981 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/249) <!-- Reviewable:end -->
|
|
tyagiarpit
added a commit
to tyagiarpit/servo
that referenced
this pull request
Mar 23, 2016
Make the script that checks for undefined Android symbols compatible with both Python 2 and Python 3, to allow for future updates to the default system Python on our build machines. I'd like to land this before servo/saltfs#249. We currently use Ubuntu 14.04 (an LTS release); Ubuntu is aiming for Python 3 as the default Python in the next LTS release, 16.04, and I'd like to have any scripts be ready for the transition.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…ndroid binary #8351 (from cengizIO:master); r=larsbergstrom Tries to fix #8351. This is meaningful only with the PR to servo/saltfs Cross PR: servo/saltfs#249 Source-Repo: https://github.com/servo/servo Source-Revision: 1db70db28444708df05dda1b3b38c75aa4f36505 UltraBlame original commit: ecfdcfb914d570c2190328588b092200a31aeec4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…ecker (from aneeshusa:make-dynamic-symbol-checking-script-python3-compatible); r=Ms2ger Make the script that checks for undefined Android symbols compatible with both Python 2 and Python 3, to allow for future updates to the default system Python on our build machines. I'd like to land this before servo/saltfs#249. We currently use Ubuntu 14.04 (an LTS release); Ubuntu is aiming for Python 3 as the default Python in the next LTS release, 16.04, and I'd like to have any scripts be ready for the transition. Do we have a Python 2/3 compatibility policy? cc cengizIO larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: 691367745ad27ef79d67e4dc9be679eb969fdd96 UltraBlame original commit: 50690e204967d44b72382654f03a6f4de4373ca4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…ndroid binary #8351 (from cengizIO:master); r=larsbergstrom Tries to fix #8351. This is meaningful only with the PR to servo/saltfs Cross PR: servo/saltfs#249 Source-Repo: https://github.com/servo/servo Source-Revision: 1db70db28444708df05dda1b3b38c75aa4f36505 UltraBlame original commit: ecfdcfb914d570c2190328588b092200a31aeec4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…ecker (from aneeshusa:make-dynamic-symbol-checking-script-python3-compatible); r=Ms2ger Make the script that checks for undefined Android symbols compatible with both Python 2 and Python 3, to allow for future updates to the default system Python on our build machines. I'd like to land this before servo/saltfs#249. We currently use Ubuntu 14.04 (an LTS release); Ubuntu is aiming for Python 3 as the default Python in the next LTS release, 16.04, and I'd like to have any scripts be ready for the transition. Do we have a Python 2/3 compatibility policy? cc cengizIO larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: 691367745ad27ef79d67e4dc9be679eb969fdd96 UltraBlame original commit: 50690e204967d44b72382654f03a6f4de4373ca4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…ndroid binary #8351 (from cengizIO:master); r=larsbergstrom Tries to fix #8351. This is meaningful only with the PR to servo/saltfs Cross PR: servo/saltfs#249 Source-Repo: https://github.com/servo/servo Source-Revision: 1db70db28444708df05dda1b3b38c75aa4f36505 UltraBlame original commit: ecfdcfb914d570c2190328588b092200a31aeec4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…ecker (from aneeshusa:make-dynamic-symbol-checking-script-python3-compatible); r=Ms2ger Make the script that checks for undefined Android symbols compatible with both Python 2 and Python 3, to allow for future updates to the default system Python on our build machines. I'd like to land this before servo/saltfs#249. We currently use Ubuntu 14.04 (an LTS release); Ubuntu is aiming for Python 3 as the default Python in the next LTS release, 16.04, and I'd like to have any scripts be ready for the transition. Do we have a Python 2/3 compatibility policy? cc cengizIO larsbergstrom Source-Repo: https://github.com/servo/servo Source-Revision: 691367745ad27ef79d67e4dc9be679eb969fdd96 UltraBlame original commit: 50690e204967d44b72382654f03a6f4de4373ca4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cengizIO commentedMar 14, 2016
Tries to fix #8351.
This is meaningful only with the PR to servo/servo
Cross PR: servo/servo#9981
This change is