This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Deploy Mozilla-recommended sshd config#254
Closed
edunham wants to merge 1 commit intoservo:masterfrom
Closed
Conversation
Contributor
Author
|
Failure is due to root group being unavailable on Mac. Does Salt have a platform-agnostic way of specifying the correct perms or inheriting them from the directory? |
Contributor
|
This has actually been on my mind for a while (and is something I've been investigating), and a robust fix is going to be quite a bit more involved. I'll cycle back to this after #253 is landed. |
Contributor
|
☔ The latest upstream changes (presumably #577) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
Fixed the blocker of my Salt ignorance here by cribbing off how the admin state handles the hosts file. Cherry-picked and closing in favor of #628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://wiki.mozilla.org/Security/Guidelines/OpenSSH
r? @aneeshusa
Please do not merge until #253 is landed and verified working by everyone. These changes will disallow root login.
This change is