Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upNDK installation should run whenever it's not installed #259
Conversation
According to https://docs.saltstack.com/en/latest/ref/states/all/salt.states.cmd.html#should-i-use-cmd-run-or-cmd-wait, ndk installation will only try to run if the ndk was just downloaded. In the old implementation, if you succeed at downloading the ndk but fail to install it, subsequent highstates won't attempt to install the ndk because the downloaded file will be unchanged.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 21, 2016
NDK installation should run whenever it's not installed According to https://docs.saltstack.com/en/latest/ref/states/all/salt.states.cmd.html#should-i-use-cmd-run-or-cmd-wait, ndk installation will only try to run if the ndk was just downloaded. In the old implementation, if you succeed at downloading the ndk but fail to install it, subsequent highstates won't attempt to install the ndk because the downloaded file will be unchanged. With these changes, we decide whether to install the ndk based on whether the directory created by installation exists, rather than based on whether we downloaded the file this run. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/259) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 21, 2016
NDK installation should run whenever it's not installed According to https://docs.saltstack.com/en/latest/ref/states/all/salt.states.cmd.html#should-i-use-cmd-run-or-cmd-wait, ndk installation will only try to run if the ndk was just downloaded. In the old implementation, if you succeed at downloading the ndk but fail to install it, subsequent highstates won't attempt to install the ndk because the downloaded file will be unchanged. With these changes, we decide whether to install the ndk based on whether the directory created by installation exists, rather than based on whether we downloaded the file this run. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/259) <!-- Reviewable:end -->
|
|
|
|
|
I'm almost ready to put in the PR I mentioned in #239 which touches the Android stuff heavily, and it's going to have merge conflicts with this/includes some of this work already. Can we hold off on this PR please? Also, this isn't quite right - we still need to keep a requisite to |
Merged
bors-servo
added a commit
that referenced
this pull request
Mar 22, 2016
Android refactor Main highlights: - Update to SHA512 hashes and HTTPS URLs - Use multiple directories + symlinks to be more robust during version updates for Android - Moves states around to make their purpose more clear Helps with #209. Supersedes #259, #260. cc @larsbergstrom @edunham I recommend reviewing this commit by commit and reading the commit messages - feel free to ask questions. Also, we should check that this doesn't break buildbot; I don't know how to do that. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/263) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedMar 21, 2016
According to
https://docs.saltstack.com/en/latest/ref/states/all/salt.states.cmd.html#should-i-use-cmd-run-or-cmd-wait,
ndk installation will only try to run if the ndk was just downloaded.
In the old implementation, if you succeed at downloading the ndk but fail to
install it, subsequent highstates won't attempt to install the ndk because the
downloaded file will be unchanged.
With these changes, we decide whether to install the ndk based on whether the directory created by installation exists, rather than based on whether we downloaded the file this run.
This change is