Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version of the NDK #260

Closed
wants to merge 1 commit into from
Closed

updated version of the NDK #260

wants to merge 1 commit into from
+1 −1

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 21, 2016

r? @edunham
I think this gets overridden by the env variables set by the buildbot master.cfg, but it was bugging me to have these incorrect.

This change is Reviewable
@larsbergstrom
updated version of the NDK
Loading status checks…
fb1fbc7
@aneeshusa
Copy link
Member

aneeshusa commented Mar 22, 2016

Heads up - sorry about the delay, but I'm almost ready to put in the PR I mentioned about updating Android in #239. Two things:

  • I'm pretty sure that the bash_profile file is only used to set these environment variables for interactive usage, not buildbot. Does anybody use these? If not, I'd be ok with getting rid of this file.
  • The changes in my PR will make this PR redundant, so let's hold off on merging this one.
@aneeshusa aneeshusa mentioned this pull request Mar 22, 2016
Merged
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Mar 22, 2016

@aneeshusa That's awesome! I didn't want to bug you about the PR, as I assumed you were busy :-) This will be a huge help. @edunham and I have a fairly comprehensive idea about everything that's currently broken in the Android rules, from bloody experience.

I'll just close this in favor of your work.

Also, you're correct that we shouldn't need the bash_profile anymore.
@aneeshusa
Copy link
Member

aneeshusa commented Mar 22, 2016

If we don't need the bash_profile, I'll go ahead and get rid of it in the other PR.
@aneeshusa
Copy link
Member

aneeshusa commented Mar 22, 2016

Also, feel free to poke me about stuff like that - I did have a busy week but I've got free time this week.

If there's anything else broken with the Android rules that isn't covered by my PR, please open some issues or let me know!
bors-servo added a commit that referenced this pull request Mar 22, 2016
@bors-servo
Auto merge of #263 - aneeshusa:android-refactor, r=edunham
Loading status checks…
b5173aa 
Android refactor

Main highlights:
  - Update to SHA512 hashes and HTTPS URLs
  - Use multiple directories + symlinks to be more robust during version updates for Android
  - Moves states around to make their purpose more clear

Helps with #209.
Supersedes #259, #260.

cc @larsbergstrom @edunham

I recommend reviewing this commit by commit and reading the commit messages - feel free to ask questions.

Also, we should check that this doesn't break buildbot; I don't know how to do that.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/263)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@larsbergstrom @aneeshusa
You can’t perform that action at this time.